Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readability of code by using if expression #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pjljvandelaar
Copy link

The code is simplified by using if expressions (and simplifying that when possible).

This pull requests solves #5

Problem detected and solved by Rejuvenation-Ada crate
vote for Rejuvenation-Ada as The 2022 Ada Crate Of The Year

@pjljvandelaar
Copy link
Author

If this merge is accepted,
I could also check for the usage of short circuit versions of Boolean operators:

See e.g.
https://github.com/TNO/Rewriters-Ada/blob/47ca5f092d736ce7ab86a0214008023dd59b2f4f/src/predefined_rewriters_prefer_short_circuit.ads#L26-L31

@gusthoff
Copy link
Collaborator

gusthoff commented Dec 9, 2022

Sorry for the delay: I'll take a look into your changes as soon as I have some spare time.

Feel free to perform others checks. The only thing I'd like to ask you, though, is to avoid creating an issue and a pull request at the same time: creating a pull request alone is more than sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants