Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carets -- Lauren Cardella & Victoria Sawchuk #18

Open
wants to merge 32 commits into
base: master
Choose a base branch
from

Conversation

vsawchuk
Copy link

Video Store Consumer

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
For each person in your pair, describe something you learned from your partner during this project Victoria: I learned about the slideToggle functionality in Backbone from Lauren - it's how we displayed the overview of each movie.
What was one area of Backbone you gained more clarity on during this assignment? It was nice to learn a little bit more about the API calls that Backbone built-in functions can make, and how those work.
Describe how you solved the problem of having lists of movies that look mostly the same but have different content We used separate templates for two MovieListViews that differentiated the IMDB and Library views - but I just learned we could have used a conditional in the template!
Describe how you handled rentals with Backbone? We did not.
Describe a DOM event your application handled You can click "show details" on a movie card to expand out the movie's overview.
Describe a custom event your application handled You can add a movie to your rental inventory - the rentalListView instance of MovieListView listens for an event, creates a hash with the necessary object attributes and adds the object to it's model (a collection of movies).
Do you have any recommendations on how we could improve this project for the next cohort?

vsawchuk and others added 30 commits December 18, 2017 10:56
…to reset the URL with the query parameter added.
…l form in movie view. Form is not showing in the right place.
…lt speed. Add hide function to remove the other div if displayed when the button is clicked.
…omer list and list view in app.js. Customer list renders in the browser.
@enigmagnetic
Copy link

I'm not sure I can edit the original pull request comment, so I am adding my answer to the comprehension question here.

Victoria helped me better understand the flow of events through Backbone Models, Collections and Views.

@CheezItMan
Copy link

Video Store Consumer

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene - pair contribution Well done
Comprehension questions Check
General
Search functionality Check
Rental library listing functionality Check
Add to rental library functionality Check
Underscore Templates Check
Overall Look & feel Nice overall, I like the slide effect when showing details.
Optionals No rental functionality
Overall Good work you hit all the learning goals. I'm glad you noticed that you could have just used a conditional in the template.


const MovieList = Backbone.Collection.extend({
model: Movie,
url: 'http://localhost:3000/movies/',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also make url a function like:

url() {
  return query ? `http://localhost:3000/movies/${query}`:  'http://localhost:3000/movies/';
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants