Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carets -- Isabel & Guille #8

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open

Conversation

murog
Copy link

@murog murog commented Dec 20, 2017

Video Store Consumer

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
For each person in your pair, describe something you learned from your partner during this project Isabel learned about making sure that the templates are properly scoped with the correct element. In the past, she has experience losing time in debugging to only find out that the element was too narrow in focus. Guille learned about efficiently debugging with a rails back end. Specifically, how to use the success attribute of the fetch function to look into what information is passed in the response and options. We were able to grab responseJSON and HTTP status codes from the options object. It was cool. Seriously.
What was one area of Backbone you gained more clarity on during this assignment? We gained more clarity on the save/create methods. Specifically, how to handle HTTP requests on a rails back end with a different front end (CORS).
Describe how you solved the problem of having lists of movies that look mostly the same but have different content We created different views (vendorListView and movieListView) that initialized with different collections that sourced from the same model.
Describe how you handled rentals with Backbone? Unfortunately, we were unable to handle Rentals. However, we were able to distinguish between our "rental library" that were saved to a MovieList collection from movies queried from the TMDB API.
Describe a DOM event your application handled We had click events on a button titled "add to library." This click event was stored in a event object within the VendorView. Upon the DOM event of "click", we did a callback to a function that would eventually trigger an event to check whether the movie existed in our rental library and add it to the rails back end.
Describe a custom event your application handled Similarly to the event we described above, the click event would eventually trigger a custom event. The custom event that was triggered in this case was "addtoLibrary." This was passed along on our event bus to the movie list, which would listen for it and implement to its own addToLibrary function.
Do you have any recommendations on how we could improve this project for the next cohort? We both really enjoyed strengthening our understanding of Backbone (especially after BACKTrek). It was also helpful to combine it with a rails API that we could modify. Maybe in the future, have more back end components to this project to build more upon the "full stack."

murog and others added 30 commits December 18, 2017 10:52
…e of searching collection regardless of case, added movie details template and rendering of movie details (currently not working)
…its collection, updateStatusMessageWith checks is movie is valid and appends appropriate message to user
…n contains the movie it will report to user that the movie already exists in collection
@CheezItMan
Copy link

Video Store Consumer

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene - pair contribution Check
Comprehension questions I'm glad you learned some cool stuff!
General
Search functionality Check
Rental library listing functionality Yes although the images aren't working, it seems that the API needs a bit of work to fix this
Add to rental library functionality Check
Underscore Templates Check
Overall Look & feel Simple, but it works
Optionals
Overall You hit all the major learning goals. There's a small bug with images from the existing movies in the DB. Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants