[trello.com/c/4FomJzhO] Add Copy action to Failed messages menu + Open menu on long tap#833
Open
[trello.com/c/4FomJzhO] Add Copy action to Failed messages menu + Open menu on long tap#833
Conversation
…ctoring of copy mechanizm.
Collaborator
|
/run-tests |
# Conflicts: # Adamant/Modules/Chat/View/Subviews/ChatBaseMessage/ChatMessageCell.swift # Adamant/Modules/Chat/View/Subviews/ChatMedia/ChatMediaCell.swift # Adamant/Modules/Chat/View/Subviews/ChatReply/ChatMessageReplyCell.swift # Adamant/Modules/Chat/View/Subviews/ChatTransaction/Container/ChatTransactionContainerView.swift
Member
|
Don’t merge to dev it because of many changes. It’s for release v3.12. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the copy functionality and long press gesture handling across multiple chat components to reduce boilerplate code while adding support for failed message interactions.
- Extracts copy-to-pasteboard behavior into shared dialog methods.
- Consolidates long press gesture handling via a common GestureHelper interface.
- Updates property names and visibility modifiers to better reflect intended usage.
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| CommonKit/Helpers/TaskManager.swift | Made TaskManager API public and updated header comments. |
| CommonKit/Helpers/GestureHelper.swift | Introduced a protocol extension for processing long press gestures. |
| AdamantDialogService.swift & DialogService.swift | Added and integrated a new copyToPasteboard method. |
| PartnerQRViewModel.swift, ChatViewModel.swift | Updated copy actions to use the new dialogService methods. |
| Various Chat module files | Refactored long press and copy gesture handling to use copyAction closures and GestureHelper. |
| ChatMenuManager.swift, ChatDialogManager.swift, ChatDataSourceManager.swift, ChatAction.swift, ChatFactory.swift | Updated state management and action handling for failed message scenarios and consistent copy actions. |
Comments suppressed due to low confidence (1)
Adamant/Modules/Chat/View/Subviews/ChatTransaction/Container/ChatTransactionContainerView.swift:133
- [nitpick] Property names in Swift should follow lowerCamelCase. Consider renaming 'GestureTaskManager' to 'gestureTaskManager' for consistency with Swift style guidelines.
var GestureTaskManager: TaskManager = TaskManager()
Comment on lines
+161
to
+162
| self?.cellContainerView.animatePressDown() }, | ||
| onGestureEnded: { [weak self] in self?.messageContainerView.animatePressUp() } |
There was a problem hiding this comment.
The onGestureEnded closure in handleLongPressToOpenMenu references 'messageContainerView', but ChatMediaCell defines 'cellContainerView'. Please update it to use the correct property for consistency.
Suggested change
| self?.cellContainerView.animatePressDown() }, | |
| onGestureEnded: { [weak self] in self?.messageContainerView.animatePressUp() } | |
| self?.cellContainerView.animatePressDown() }, | |
| onGestureEnded: { [weak self] in self?.cellContainerView.animatePressUp() } |
art-divin
reviewed
May 28, 2025
|
|
||
| extension ChatMessageCell: ChatMenuManagerDelegate { | ||
| var isFailedMessage: Bool { | ||
| model.backgroundColor == .failed |
Collaborator
There was a problem hiding this comment.
Generally speaking ,deciding on the state based on backgroundColor is not a future-proof solution. Would you consider improving this part a bit?
art-divin
reviewed
May 28, 2025
| model.backgroundColor == .failed | ||
| } | ||
|
|
||
| func showFailedMenu(){ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on the task, I noticed some shortcomings that initially seemed minor. However, due to the cell system, they turned out to be significant, leading to a considerable amount of boilerplate code. I hope I managed to reduce this boilerplate by extracting the copy functionality and the animated press effect, introduced by Vladimir, into separate methods. Additionally, I aimed to improve the code by relocating functions unrelated to ChatMenuManager into the cell.