fix: bind macOS chat context menu overlay to active window scene#940
Open
ukgorclawbot-stack wants to merge 1 commit intoAdamant-im:developfrom
Open
fix: bind macOS chat context menu overlay to active window scene#940ukgorclawbot-stack wants to merge 1 commit intoAdamant-im:developfrom
ukgorclawbot-stack wants to merge 1 commit intoAdamant-im:developfrom
Conversation
Author
|
/run-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UIWindowSceneas the source chat viewRoot Cause
The macOS chat context menu uses a custom overlay
UIWindow. It was created once withTransparentWindow(frame:)and then reused across later presentations. After background/restore, the right-click interaction still fired, but the overlay could be left attached to a stale window lifecycle instead of the currently active chat scene.What Changed
UIWindowScenefromcopyView.window?.windowScene, with a foreground/key-window fallbackVerification
git diff --checkxcrun --sdk iphonesimulator --show-sdk-pathfails. Please use CI //run-testsfor the simulator validation.Closes #912