Skip to content

fix: Trying to round a string in ui_manage#324

Merged
OH296 merged 1 commit intoAdeptus-Dominus:release/0.10.0.0from
OH296:fix/ui_manage
Dec 26, 2024
Merged

fix: Trying to round a string in ui_manage#324
OH296 merged 1 commit intoAdeptus-Dominus:release/0.10.0.0from
OH296:fix/ui_manage

Conversation

@OH296
Copy link
Collaborator

@OH296 OH296 commented Dec 26, 2024

Summary by Sourcery

Bug Fixes:

  • Prevent error when displaying experience value if it is not a number.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 26, 2024

Reviewer's Guide by Sourcery

This pull request fixes a bug in scr_ui_manage.gml where experience was being rounded when it should not have been.

File-Level Changes

Change Details Files
Removed rounding of experience value
  • Removed the round function call when displaying the experience value, which was causing the experience value to be rounded when it should not have been rounded.
  • Changed the experience value from being rounded to being displayed as a string without rounding it first.
scripts/scr_ui_manage/scr_ui_manage.gml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the Type: Fix This is a fix for a bug label Dec 26, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @OH296 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider implementing proper type handling for temp[113] - if it's meant to store numeric experience values, it should probably be stored and handled as a number rather than a string to prevent type-related issues.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@OH296 OH296 merged commit 7041b90 into Adeptus-Dominus:release/0.10.0.0 Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Fix This is a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant