fix: Minor scoping error in one of the new ship return events

[OH296]

Summary by Sourcery

Bug Fixes:

• Fix an issue where piety was not correctly used when calculating corruption for returned ships.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request fixes a minor scoping error in the return_lost_ship function. The error caused the piety of the first unit in the _units array to be used for all units when calculating corruption. This has been fixed by correctly indexing the _units array when accessing individual units.

File-Level Changes

Change	Details	Files
Fixed a scoping error in the corruption calculation.	Corrected the indexing of the _units array within the loop to properly access the current unit's piety during corruption calculation. Changed _units.edit_corruption to _units[i].edit_corruption to correctly reference the current unit in the array based on the loop index i.	scripts/scr_player_ship_functions/scr_player_ship_functions.gml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @OH296 - I've reviewed your changes - here's some feedback:

Overall Comments:

• The fix for _units.edit_corruption looks good, but there appears to be another scoping issue: '_unit.piety' should probably be '_units[i].piety' to match the array indexing pattern

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}