-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add PR title validation workflow #341
Conversation
Reviewer's Guide by SourceryThis pull request introduces a new CI workflow to enforce PR title formatting. The workflow uses the File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @EttyKitty - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding explicit configuration for the allowed PR title formats in the workflow file to make it more self-documenting. The action supports this via the
configuration_path
parameter.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟡 Security: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @EttyKitty - I've reviewed your changes - here's some feedback:
Overall Comments:
- The PR is missing the referenced configuration file
.github/pr-title-checker-config.json
which is required for this workflow to function. Please add the configuration file with the desired title validation rules.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟡 Security: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @EttyKitty - I've reviewed your changes - here's some feedback:
Overall Comments:
- The PR is missing the required
.github/pr-title-checker-config.json
configuration file that defines the allowed title formats. The workflow will fail without this file.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟡 Security: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
- Validate pull request titles using the `thehanimo/pr-title-checker` GitHub Action.
Description of changes
thehanimo/pr-title-checker
action.Reasons for changes
Related links
Summary by Sourcery
CI:
thehanimo/pr-title-checker
GitHub Action.