feat: Founding traits

[KRdaMystic]

Description of changes

-Adds starting traits for marines in founding chapters.

Reasons for changes

-Add more variance between the 9 founding chapters.

Related links

-The project

Summary by Sourcery

New Features:

• Introduced unique starting traits for each of the nine founding chapters of Space Marines to increase variance and diversity between them.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request adds new starting traits for marines in the nine founding chapters to increase variance between them. It modifies the scr_unit_traits.gml file by adding several new traits to the global.trait_list and updating the global.astartes_trait_dist to include the new traits and their associated chapters.

File-Level Changes

Change	Details	Files
Added new traits for each founding chapter	Added "students_of_war" trait for Ultramarines. Added "secretive_knights" trait for Dark Angels. Added "warriors_of_the_Wind" trait for White Scars. Added "wolf_prince" trait for Space Wolves. Added "shadow_masters" trait for Raven Guard. Added "keepers_of_the_flame" trait for Salamanders. Added "will_of_iron" trait for Iron Hands. Added "host_of_angels" trait for Blood Angels. Added "obstinate_defenders" trait for Imperial Fists.	scripts/scr_unit_traits/scr_unit_traits.gml
Updated trait distribution for Astartes	Added entries to global.astartes_trait_dist to include distribution information for the new traits. Associated each new trait with its corresponding founding chapter in the distribution settings. Adjusted the distribution settings to ensure the new traits are applied correctly during unit creation based on chapter affiliation.	scripts/scr_unit_traits/scr_unit_traits.gml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @KRdaMystic - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider extracting the [500,0] magic numbers into named constants to improve code readability and maintainability

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}