Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Custom role saving #345

Merged

Conversation

VanWeapon
Copy link
Contributor

@VanWeapon VanWeapon commented Dec 28, 2024

Description of changes

  • Fixes custom roles not saving during custom chapter creation

Reasons for changes

  • bugfix

Related links

Summary by Sourcery

Bug Fixes:

  • Fix custom roles not being saved during chapter creation.

Copy link
Contributor

sourcery-ai bot commented Dec 28, 2024

Reviewer's Guide by Sourcery

This PR fixes a bug where custom roles were not being saved during custom chapter creation. The fix involves saving the custom roles to the obj_creation.custom_roles variable and then updating the global.chapter_creation_object with the saved roles. Additionally, the custom_roles variable is initialized as an empty struct in the scr_chapter_random script.

File-Level Changes

Change Details Files
Save custom roles during chapter creation
  • Added code to save custom roles to obj_creation.custom_roles during custom chapter creation.
  • Added custom_roles to global.chapter_creation_object in scr_save_chapter.
  • Initialized custom_roles as an empty struct in scr_chapter_random.
objects/obj_creation_popup/Draw_0.gml
scripts/scr_chapter_new/scr_chapter_new.gml
scripts/scr_save_chapter/scr_save_chapter.gml
scripts/scr_chapter_random/scr_chapter_random.gml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the PR: Fix This is a fix for a bug label Dec 28, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @VanWeapon - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@VanWeapon VanWeapon self-assigned this Dec 28, 2024
@EttyKitty EttyKitty merged commit ff8f970 into Adeptus-Dominus:release/0.10.0.0 Dec 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Fix This is a fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants