feat: Combat adjustments

[KRdaMystic]

This PR migrated from here EttyKitty#163.

As per original description:

Intent:

• Create a definite Hierarchy for weapons including tiers and classes to ensure player has meaningful armament choice and progression in the Armamentarium for his marine's equipment.

• Rebalance damage and max kill values in line with the established hierarchy and class system.

• Balance durability for all ground units so that chapters can tackle targets as less than a doom stack.

• Create descriptive guide documentation for each weapon class so as to guide future additions. (Half way done)

Desired End-state

• Weapons are tangible choices with trade-offs that affect battle outcomes.

• Squad loadouts are more indicative of intended battlefield role (Tank hunters and Horde breakers).

Noticeable changes

• Heavy Bolter is no longer AP.
• Missile Launcher is now -1 AP. (Low Penetration)
• Add "martial" and "savage" weapon tags to enable custom stat scaling for melee attacks.
• Rewrite the melee damage formula, to account for the new tags and be less extreme in general.
• Adds functionality to boarding 1-3 tagged weapons.

Notes

A related PR: #315
A structured doc with all said rebalance changes:
https://docs.google.com/spreadsheets/d/1ZMPRXjmd3tWvFmWiIYb-nQ9qT5PYPiu_75SJNhcYqvg/edit?gid=1993273333#gid=1993273333

Summary by Sourcery

Rebalance weapon stats, introduce weapon tags for melee combat, and add boarding actions.

New Features:

• Added "martial" and "savage" weapon tags to enable custom stat scaling for melee attacks.
• Added boarding actions, allowing marines to board enemy ships with 1-3 tagged weapons.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR introduces a comprehensive rebalance of combat mechanics, focusing on weapon hierarchy, damage values, unit durability, and melee combat adjustments. It also adds "boarding" weapon tags and functionality.

File-Level Changes

Change	Details	Files
Adjusted weapon stats and tags, introducing a weapon hierarchy system to provide more meaningful choices and progression.	Rebalanced damage and max kill values for various weapons. Added "martial" and "savage" weapon tags to enable custom stat scaling for melee attacks. Added "boarding" tags to weapons for boarding actions.	scripts/scr_weapon/scr_weapon.gml
Rewrote the melee damage formula to incorporate new tags and provide a less extreme damage curve.	Updated melee attack calculation to consider "martial" and "savage" tags, weapon skill, strength, dexterity, experience, and psionic abilities. Added logic to handle encumbrance and sidearm bonuses in melee combat.	scripts/scr_marine_struct/scr_marine_struct.gml
Implemented boarding action functionality based on weapon tags.	Added logic to calculate boarding success based on unit stats, weapon tags, and target properties. Implemented different outcomes for boarding actions, including damage, stealing, and ship destruction.	objects/obj_p_assra/Step_0.gml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @KRdaMystic - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider implementing damage increases more gradually across multiple updates to better assess balance impact. The code improvements look great but such large jumps in damage values (e.g. Chainsword 50->130) could be disruptive.

Here's what I looked at during the review

• 🟡 General issues: 2 issues found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[OH296]

Good changes all round

[EttyKitty]

My only note (as others may be out of the scope of this PR) is this:

• Re some of the weapon buffs: I saw, namely, that Missile launcher is now AP, has buffed damage and 3 times more spli. My only concern, in this case and other similar cases, is how it compares to its current price that is still unchanged?

[KRdaMystic]

I meant to remove the AP on it for now until I came up with a better armor pen formula

[KRdaMystic]

@sourcery-ai review

[sourcery-ai]

Hey @KRdaMystic - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[OH296]

My only note (as others may be out of the scope of this PR) is this:

• Re some of the weapon buffs: I saw, namely, that Missile launcher is now AP, has buffed damage and 3 times more spli. My only concern, in this case and other similar cases, is how it compares to its current price that is still unchanged?

Reading through actually i am also reading some issues.
Player weaponry in general seems to be suffering from a near continuous power creep from constant buffing without ever touching enemy weaponry, for example(taken somewhat randomly) why have meltaguns been given spli value of 6 this has essentially made them a horde killer in one fell swoop.
There have been maybe 3 or 4 big refurbs of weapons done by people that constantly are boosting weapon values i think generally as a response to the writers preferred choices and as they knit together these tweaks are becoming more and more un-sutainable.

@EttyKitty not sure what you think on this or what the position is

@KRdaMystic this is also not really about this pr as a whole but i think it needs to be considered