Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : improve ordering and reduce duplicate line scr_add_man #355

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

OH296
Copy link
Collaborator

@OH296 OH296 commented Dec 29, 2024

fixes- https://discord.com/channels/714022226810372107/1120687959365128243/threads/1322910920816721980

Summary by Sourcery

Bug Fixes:

  • Fix the order of operations when adding experience and updating the role of a new marine.

Copy link
Contributor

sourcery-ai bot commented Dec 29, 2024

Reviewer's Guide by Sourcery

This PR improves the ordering of operations in the scr_add_man function and reduces duplicate lines. The changes ensure that experience points are added after the unit is initialized and its equipment is altered. The role of the unit is also updated after the unit is allocated to its spawn point.

File-Level Changes

Change Details Files
Adds experience points and updates the unit role after initialization and equipment alteration.
  • Moved unit.add_exp(spawn_exp) after the equipment alteration and age rolling.
  • Moved unit.update_role(man_role) to after unit allocation.
scripts/scr_add_man/scr_add_man.gml
Fetches and stores the unit after wiping.
  • Added unit = fetch_unit([target_company,good]); after wiping the unit.
scripts/scr_add_man/scr_add_man.gml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the PR: Fix This is a fix for a bug label Dec 29, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @OH296 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@OH296 OH296 merged commit 8418c61 into Adeptus-Dominus:release/0.10.0.0 Dec 29, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Fix This is a fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant