fix: Vehicle purchase

[OH296]

• brings the scr_add_vehicle script in line with the changes to variable array lengths with ships

Summary by Sourcery

Bug Fixes:

• Fix an issue with adding vehicles to companies with variable-length ship arrays.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR updates the scr_add_vehicle script to handle variable array lengths for ships. It replaces repeat loops with for loops that iterate over the specific array length using array_length. This change ensures that the script correctly handles ship arrays of varying sizes, preventing potential issues with out-of-bounds access.

File-Level Changes

Change	Details	Files
Replaced repeat loops with for loops to handle variable array lengths	Changed repeat(150) to for (var i=0;i<array_length(veh_role[target_company]);i++) to iterate over the actual length of the veh_role array. Changed repeat(30) to for (var i=0; i<array_length(obj_ini.ship_class);i++) to iterate over the actual length of the obj_ini.ship_class array. Added a break statement within the first for loop to exit the loop once a suitable value for good is found, improving efficiency. Modified conditional checks using else if to ensure correct logic when checking for available ships.	scripts/scr_add_vehicle/scr_add_vehicle.gml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @OH296 - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}