-
Notifications
You must be signed in to change notification settings - Fork 37
feat: Improve Obliterated trait (balance) #364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improve Obliterated trait (balance) #364
Conversation
gives obliterated a fighting chance.
Reviewer's Guide by SourceryThis pull request modifies the \ Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @KRdaMystic - I've reviewed your changes - here's some feedback:
Overall Comments:
- The removal of
siege = 0
for the Obliterated trait isn't mentioned in the description. Was this intentional? If so, please document this change in the PR description.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
gives obliterated a fighting chance.
Description of changes
-Adds one specialist to each of the offices to avoid inquisition penalties
-Strength points over 5 now count for 10 scouts in place of 5
-removed the
siege = 0
from obliterated's block of codeReasons for changes
Summary by Sourcery
Rebalance the "Obliterated" trait by reducing penalties to specialist counts and increasing the scout bonus for strength points above 5.
Bug Fixes:
Enhancements: