fix: A couple of missed old trait checks

[EttyKitty]

Description of changes

• Fixes a couple of missed trait checks with old methods, causing crashes.
• Minor refactor to if/else checks, for clarity.

Reasons for changes

• Got a couple of crashes without this.

Related links

• refactor: trait usage standardisation  #376

How have you tested your changes?

• Compile
• New game
• Next turn
• Space Travel
• Ground Battle

Summary by Sourcery

Bug Fixes:

• Fix crashes caused by missing trait checks with old methods.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request fixes a couple of edge cases that caused crashes due to missing trait checks. It also includes a minor refactor of if/else statements for improved clarity.

File-Level Changes

Change	Details	Files
Replaced direct string comparisons with calls to scr_has_adv()	Uses the function scr_has_adv() to check for advantages like "Enemy: Eldar", "Ambushers", and "Crafters" instead of directly checking string values in obj_ini.strin. Simplifies the logic and makes the code more readable and maintainable.	scripts/scr_dialogue/scr_dialogue.gml objects/obj_controller/Create_0.gml objects/obj_ground_mission/Alarm_4.gml objects/obj_ground_mission/Alarm_5.gml scripts/scr_initialize_custom/scr_initialize_custom.gml
Refactored if/else statements	Improved the structure and readability of if/else statements within the scr_dialogue function. No changes in functionality, only improved code clarity.	scripts/scr_dialogue/scr_dialogue.gml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @EttyKitty - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}