Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sprite): Iron halo display position on Artificer armor #383

Merged

Conversation

EttyKitty
Copy link
Collaborator

@EttyKitty EttyKitty commented Jan 5, 2025

Description of changes

  • Remove old offset of iron halo for artificer armor. I think it was there because of the old artificer sprite, that had a huge backpack.

Reasons for changes

  • Iron halo was hovering, separate from the marine.

Related links

How have you tested your changes?

  • Compile
  • New game
  • Next turn
  • Space Travel
  • Ground Battle

Summary by Sourcery

Bug Fixes:

  • Correct the vertical offset of the iron halo for units equipped with Artificer armor, aligning it properly with the marine sprite.

Copy link
Contributor

sourcery-ai bot commented Jan 5, 2025

Reviewer's Guide by Sourcery

This PR fixes the display position of the iron halo on units wearing Artificer armor by removing an offset that was previously applied to the halo's vertical position. The offset was likely introduced to accommodate the old artificer sprite, which had a large backpack. With the new sprite, this offset is no longer necessary and causes the halo to hover above the unit.

File-Level Changes

Change Details Files
Removed the vertical offset applied to the iron halo for units with Artificer armor.
  • Deleted the conditional check for "Artificer Armour" and the corresponding vertical offset adjustment of -14 pixels within the scr_draw_unit_image function.
  • The iron halo position for Artificer armor now relies on the default offset logic, ensuring it is correctly positioned on the marine's model rather than hovering above it.
scripts/scr_draw_unit_image/scr_draw_unit_image.gml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the PR: Fix This is a fix for a bug label Jan 5, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @EttyKitty - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@EttyKitty EttyKitty merged commit 7f91d65 into Adeptus-Dominus:release/0.10.0.0 Jan 6, 2025
3 checks passed
@EttyKitty EttyKitty deleted the bugfix/iron-halo branch January 6, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Fix This is a fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant