fix: Variable scope in scr_add_vehicle

[EttyKitty]

Description of changes

• Fixed a crash caused by incorrect variable scope in scr_add_vehicle.

Reasons for changes

• A bug report.

Related links

• https://discord.com/channels/714022226810372107/1325240283939606653

How have you tested your changes?

• Compile
• New game
• Next turn
• Space Travel
• Ground Battle

Summary by Sourcery

Bug Fixes:

• Fixed a crash caused by incorrect variable scope in scr_add_vehicle.

Summary by Sourcery

Bug Fixes:

• Fixed a crash caused by incorrect variable scope in scr_add_vehicle.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR fixes a crash caused by incorrect variable scope in scr_add_vehicle. The variable veh_role was being accessed directly, leading to a crash. The fix involves accessing veh_role through the obj_ini instance.

File-Level Changes

Change	Details	Files
Fixed variable scope in scr_add_vehicle to prevent a crash.	Accessed veh_role through the correct scope of the obj_ini instance to resolve the crash issue.	scripts/scr_add_vehicle/scr_add_vehicle.gml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @EttyKitty - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider adding more granular error handling and cleanup in the catch blocks rather than just destroying instances. This would help ensure resources are properly released even in error cases.

Here's what I looked at during the review

• 🟡 General issues: 2 issues found
• 🟡 Security: 1 issue found
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

The merge-base changed after approval.

[EttyKitty]

@sourcery-ai review

[sourcery-ai]

Hey @EttyKitty - I've reviewed your changes - here's some feedback:

Overall Comments:

• Please verify and check off the testing items in the PR description to confirm this fix works as expected and doesn't introduce any new issues.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}