feat: Allow land speeders on raids

[OH296]

Description of changes

• Allow land speeders on raids

Reasons for changes

• allows them to be distinct function vehicles and makes good use of the new roster mechanics

Related links

How have you tested your changes?

• Compile
• New game
• Next turn
• Space Travel
• Ground Battle

Summary by Sourcery

New Features:

• Land speeders can now participate in raid missions.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request introduces a change that allows land speeders to participate in raids. This is achieved by modifying the roster selection logic to include land speeders when the selected drop location is a raid. A new array _raid_allowable is introduced to store the vehicle types allowed on raids. The _allow variable is used to determine if a vehicle should be added to the roster. The vehicle is added if it is present at the roster location and if the drop location is not an attack, it checks if the vehicle type is present in _raid_allowable.

File-Level Changes

Change	Details	Files
Added logic to allow land speeders on raids. The logic checks if the vehicle role is present in the _raid_allowable array.	Created a new array called _raid_allowable containing the vehicle types allowed on raids. Added a check within the roster selection logic to see if the selected drop location is a raid. If it is, the vehicle is only allowed if its role is present in the _raid_allowable array. Added a check to ensure that land speeders are only allowed on raids if the drop location is not an attack location. Modified the roster selection logic to include land speeders when the selected drop location is a raid and not an attack location by checking if the vehicle's role is present in the _raid_allowable array	scripts/scr_roster/scr_roster.gml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @OH296 - I've reviewed your changes - here's some feedback:

Overall Comments:

• Please perform and check off the relevant tests, especially Ground Battle testing since this affects combat mechanics

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[EttyKitty]

I may be wrong, but shouldn't the check at line 307 be if (!_allow)?

[OH296]

it's if _allow as there is no point checking if it's the correct vehicle type if it's already been determined it's in the wrong location which is what the previous checks do

[EttyKitty]

Oh, it's a second level check, sorry.
Just got confused by the two if (_allow).

[OH296]

damn missing the cats now