fix: Player ship class and arrays

[OH296]

Description of changes

• fix a bundle of array issues with fleet and ship functions
• make sure marines and vehicles are moved onto the correct ship index when killing ships

Reasons for changes

Related links

How have you tested your changes?

• Compile
• New game
• Next turn
• Space Travel
• Ground Battle

Summary by Sourcery

Fix issues with ship and fleet management functions to handle edge cases correctly.

Bug Fixes:

• Fix an issue where invalid ship indices were accessed when merging fleets.
• Fix an issue where units and vehicles were not correctly reassigned when a ship was destroyed.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR fixes a bundle of array issues with fleet and ship functions to prevent crashes caused by invalid ship indices when merging or destroying ships.

File-Level Changes

Change	Details	Files
Fixed an issue that caused crashes when merging fleets containing invalid ship indices.	Added a check to ensure that the ship index is within the bounds of the obj_ini.ship array before moving the ship between fleets.	scripts/scr_player_fleet_functions/scr_player_fleet_functions.gml
Fixed an issue that caused crashes when destroying ships with units or vehicles assigned to them.	Added a check to ensure that the unit's ship location is valid before attempting to kill the unit. Added logic to decrement the ship location of units and vehicles on ships with a higher index than the destroyed ship. Cleared vehicle variables when a ship is destroyed.	scripts/scr_ini_ship_cleanup/scr_ini_ship_cleanup.gml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @OH296 - I've reviewed your changes - here's some feedback:

Overall Comments:

• The code changes look good, but please provide more details in the PR description about what specific array issues/bugs were being fixed. This helps with future maintenance and debugging.

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[OH296]

@sourcery-ai review

[sourcery-ai]

Hey @OH296 - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}