Skip to content

feat: new skitarii base sprite#409

Merged
OH296 merged 1 commit intoAdeptus-Dominus:mainfrom
OH296:new_skittari
Jan 12, 2025
Merged

feat: new skitarii base sprite#409
OH296 merged 1 commit intoAdeptus-Dominus:mainfrom
OH296:new_skittari

Conversation

@OH296
Copy link
Copy Markdown
Collaborator

@OH296 OH296 commented Jan 10, 2025

Description of changes

  • add new skitarii base sprite by Sister Victoria

Reasons for changes

Related links

How have you tested your changes?

  • Compile
  • New game
  • Next turn
  • Space Travel
  • Ground Battle

Summary by Sourcery

New Features:

  • Added a new sprite for Skitarii units.

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Jan 10, 2025

Reviewer's Guide by Sourcery

This pull request introduces a new sprite for Skitarii units. The sprite is displayed when rendering Skitarii units. A new sprite resource spr_skitarii was created and added to the project. The rendering logic in scr_draw_unit_image was updated to use this new sprite.

File-Level Changes

Change Details Files
Added a new sprite for Skitarii units.
  • Created the spr_skitarii sprite resource file. The sprite was created by Sister Victoria.
sprites/spr_skitarii/spr_skitarii.yy
Updated the unit image drawing logic to display the Skitarii sprite.
  • Added a conditional check for "Skitarii" in the name_role() string within the scr_draw_unit_image function.
  • If the check is true, the new spr_skitarii sprite is drawn at the specified offset.
scripts/scr_draw_unit_image/scr_draw_unit_image.gml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added Area: Sprites Changes to sprites/images or their under-the-hood functionality Type: Feature Adds something new labels Jan 10, 2025
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Jan 10, 2025
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @OH296 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please fill out the 'Reasons for changes' section to provide context for why this new sprite is being added.
  • Could you please verify which test scenarios you've completed by checking the appropriate boxes in the testing section?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@OH296 OH296 changed the base branch from release/0.10.0.0 to main January 12, 2025 21:30
@OH296 OH296 dismissed sourcery-ai[bot]’s stale review January 12, 2025 21:30

The base branch was changed.

@OH296
Copy link
Copy Markdown
Collaborator Author

OH296 commented Jan 12, 2025

@sourcery-ai review

@OH296 OH296 enabled auto-merge (squash) January 12, 2025 21:30
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @OH296 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please fill out the 'Reasons for changes' section to provide context for the PR
  • The test checkboxes should be marked for the tests you've performed - at minimum, please verify compilation and basic in-game display
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@OH296 OH296 merged commit e66fb5d into Adeptus-Dominus:main Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Sprites Changes to sprites/images or their under-the-hood functionality Type: Feature Adds something new

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant