Skip to content

feat: Ground combat balance overhaul #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 35 commits into
base: main
Choose a base branch
from
Draft

Conversation

EttyKitty
Copy link
Collaborator

@EttyKitty EttyKitty commented Jan 15, 2025

This PR migrated from here EttyKitty#163.

As per original description:

Intent:

  • Create a definite Hierarchy for weapons including tiers and classes to ensure player has meaningful armament choice and progression in the Armamentarium for his marine's equipment.

  • Rebalance damage and max kill values in line with the established hierarchy and class system.

  • Balance durability for all ground units so that chapters can tackle targets as less than a doom stack.

  • Create descriptive guide documentation for each weapon class so as to guide future additions. (Half way done)

Desired End-state

  • Weapons are tangible choices with trade-offs that affect battle outcomes.

  • Squad loadouts are more indicative of intended battlefield role (Tank hunters and Horde breakers).

Noticeable changes

  • Heavy Bolter is no longer AP.
  • Missile Launcher is now -1 AP. (Low Penetration)
  • Add "martial" and "savage" weapon tags to enable custom stat scaling for melee attacks.
  • Rewrite the melee damage formula, to account for the new tags and be less extreme in general.
  • Adds functionality to boarding 1-3 tagged weapons.

Notes

A related PR: #315
A structured doc with all said rebalance changes:
https://docs.google.com/spreadsheets/d/1ZMPRXjmd3tWvFmWiIYb-nQ9qT5PYPiu_75SJNhcYqvg/edit?gid=1993273333#gid=1993273333

This comment was marked as outdated.

@github-actions github-actions bot added Type: Feature Adds something new Size: Big labels Jan 15, 2025
@EttyKitty EttyKitty added the Category: Balance Affects game balance label Jan 16, 2025
@EttyKitty EttyKitty changed the title feat: Ground combat overhaul (#352) feat: Ground combat overhaul Jan 23, 2025
@OH296 OH296 force-pushed the feat/combat-overhaul branch from 1eabd4f to 51b6826 Compare January 24, 2025 20:47
@OH296
Copy link
Collaborator

OH296 commented Jan 24, 2025

rebased onto current development

coderabbitai[bot]
coderabbitai bot previously approved these changes Feb 21, 2025
@EttyKitty EttyKitty added the Category: Improvement Makes something better label Feb 21, 2025
Copy link
Contributor

coderabbitai bot commented Mar 22, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot previously approved these changes Mar 28, 2025
coderabbitai[bot]
coderabbitai bot previously approved these changes Apr 3, 2025
Co-authored-by: EttyKitty <20323032+EttyKitty@users.noreply.github.com>
@github-actions github-actions bot added the Area: Sprites Changes to sprites/images or their under-the-hood functionality label Apr 5, 2025
Co-authored-by: EttyKitty <20323032+EttyKitty@users.noreply.github.com>
@EttyKitty EttyKitty changed the title feat: Ground combat overhaul feat: Ground combat balance overhaul Apr 7, 2025
Copy link
Contributor

This PR is marked as stale, because it has been open for 7 days with no activity.

@github-actions github-actions bot added the Status: Stale No activity for more than a week label Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Sprites Changes to sprites/images or their under-the-hood functionality Category: Balance Affects game balance Category: Improvement Makes something better Size: Warning Status: Stale No activity for more than a week Type: Feature Adds something new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants