fix: Change error handling of NameGenerator

[EttyKitty]

Description of changes

• Move error handling in the NameGenerator constructor from trying the whole constructor to individual name generation functions.
• Make error handling return error strings on catch.

Reasons for changes

• The previous method was not catching the usual errors.

Related links

• https://discord.com/channels/714022226810372107/1330236346580598855

How have you tested your changes?

• Compile
• New game
• Next turn

[sourcery-ai]

Reviewer's Guide by Sourcery

The error handling in the NameGenerator constructor has been moved from a single try-catch block encompassing the entire constructor to individual try-catch blocks within each name generation function. This change ensures that errors during name generation are caught and handled correctly, preventing the entire constructor from failing.

File-Level Changes

Change	Details	Files
Move error handling to individual name generation functions.	Removed the try-catch block from the NameGenerator constructor. Added try-catch blocks to SimpleNameGeneration, MultiSyllableNameGeneration, ComplexTitledName, and CompositeNameGeneration functions. Added a default return value of "name_error" in the catch blocks.	scripts/NameGenerator/NameGenerator.gml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @EttyKitty - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}