Skip to content

fix: custom_advisor splash images breaking game after save #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

OH296
Copy link
Collaborator

@OH296 OH296 commented Jan 19, 2025

Description of changes

  • implemented save load to obj_ini.custom_advisor

Reasons for changes

  • game break

Related links

How have you tested your changes?

  • Compile
  • New game
  • Next turn
  • Space Travel
  • Ground Battle

Copy link
Contributor

sourcery-ai bot commented Jan 19, 2025

Reviewer's Guide by Sourcery

This pull request implements saving and loading of custom advisor splash images to the game save file. This fixes a bug where the game would break after saving when custom advisor splash images were present.

File-Level Changes

Change Details Files
Implemented saving of custom advisor data.
  • Added ini_encode_and_json to save custom advisor data.
scripts/scr_save/scr_save.gml
Implemented loading of custom advisor data.
  • Added return_json_from_ini to load custom advisor data.
scripts/scr_load/scr_load.gml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the Type: Fix This is a fix for a bug label Jan 19, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @OH296 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • For a save/load fix, please verify the changes with additional test scenarios: loading existing saves (both with and without custom advisors), creating new saves with custom advisors, and loading those saves to ensure persistence works correctly.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@OH296 OH296 merged commit 84b986e into Adeptus-Dominus:main Jan 19, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Fix This is a fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants