[aws-json] Migrate SNS ListSubscriptionsByTopic #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Admiral-Piett , this is also ready to review! |
| return utils.CreateErrorResponseV1("TopicNotFound", false) | ||
| } | ||
|
|
||
| topic := app.SyncTopics.Topics[topicName] |
There was a problem hiding this comment.
You could pull this out above instead of fetching it out by key twice no?
|
|
||
| memberMap := make(map[string]app.TopicMemberResult, 2) | ||
| for _, member := range response.Result.Subscriptions.Member { | ||
| memberMap[member.SubscriptionArn] = member |
There was a problem hiding this comment.
Could we not just assert on the whole list?
app/models/responses.go
Outdated
|
|
||
| type ListSubscriptionsByTopicResult struct { | ||
| NextToken string `xml:"NextToken"` // not implemented | ||
| Subscriptions app.TopicSubscriptions `xml:"Subscriptions"` |
There was a problem hiding this comment.
Should we move app.TopicSubscriptions over here as well?
|
@kojisaikiAtSony Same here. Anything else I need to look at or can help with on this? |
We can update also this right away 👍 |
kojisaikiAtSony
force-pushed
the
feature-aws-json-list-subscription-by-topic
branch
from
77719e6 to
698729e
Compare
|
@Admiral-Piett We updated this with your feedback! |
Admiral-Piett
approved these changes
Aug 28, 2024
|
Just a rebase I think and then we're good to go! |
review ref
kojisaikiAtSony
force-pushed
the
feature-aws-json-list-subscription-by-topic
branch
from
698729e to
5728a7c
Compare
Admiral-Piett
merged commit 9159ffd
into
Admiral-Piett:feature-aws-json
2 checks passed
kojisaikiAtSony
deleted the
feature-aws-json-list-subscription-by-topic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.