[Bugfix] Cannot publish SNS with MessageAttributes via aws-json #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kojisaikiAtSony
commented
Oct 15, 2024
Comment on lines
+220
to
224
| if r.MessageAttributes == nil { | ||
| r.MessageAttributes = make(map[string]MessageAttributeValue) | ||
| } | ||
|
|
||
| r.MessageAttributes[name] = MessageAttributeValue{ |
There was a problem hiding this comment.
This line has not been tested since there is no test case for Publish with MessageAttributes.
kojisaikiAtSony
commented
Oct 15, 2024
| @@ -52,6 +56,74 @@ func Test_Publish_sqs_json_raw(t *testing.T) { | |||
| assert.Equal(t, message, string(messages[0].MessageBody)) | |||
| } | |||
|
|
|||
| func Test_Publish_Sqs_With_Message_Attributes(t *testing.T) { | |||
There was a problem hiding this comment.
Added the new test case with MessageAttributes
|
Hi @Admiral-Piett can you review this, please? |
Admiral-Piett
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found a bug when upgrade our AWS SDK to use aws-json protocol.
There is a nil access error when request SNS Publish API with MessageAttributes.