Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated explanation of example use cases #160

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Updated explanation of example use cases #160

wants to merge 3 commits into from

Conversation

asrar7787
Copy link

Purpose of this pull request

Updated explanation of example use cases in requirejs section.

Affected pages

  • commerce-frontend-core/src/pages/javascript/requirejs.md

Links to Magento Open Source code

  • N/A

jeff-matthews
jeff-matthews approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @asrar7787

@jeff-matthews jeff-matthews self-assigned this Feb 12, 2024
@jeff-matthews jeff-matthews added editorial Typo and grammar fixes or minor rewrites to correct inaccuracies internal Differentiate between community and staff member labels Feb 12, 2024
jeff-matthews
jeff-matthews reviewed Feb 12, 2024
View reviewed changes
Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove trailing space to fix validation error

src/pages/javascript/requirejs.md Outdated Show resolved Hide resolved
@jeff-matthews
Copy link
Contributor

Validation is failing on a link in an unrelated file.

@asrar7787, please add http://litmus.com/ to the .remarkrc.mjs file so we can skip that URL on the validation check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-matthews jeff-matthews jeff-matthews approved these changes

Assignees

@jeff-matthews jeff-matthews

Labels
editorial Typo and grammar fixes or minor rewrites to correct inaccuracies internal Differentiate between community and staff member
Projects
Commerce - Pull Requests
Status: 👍 Approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asrar7787 @jeff-matthews