Fix extension file cache lookup #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a version. Otherwise the extension JNLP will be downloaded a 2nd time and a second entry will be created: ::i=0\13::l=http://localhost/myapp/jnlp.extension/common.jnlp::a=1706698483984:: ::i=0\0::l=http://localhost/myapp/jnlp.extension/common.jnlp::v=6.2.3::a=1706698483198:: Because the cache lookup is called twice on extensions. The second time without the version so the versioned entry is not used. Instead a new entry i=0\13 without a version is created. This works fine as long as not a new version of common.jnlp::v=6.2.4 is lookuped. Then the sorting in line 246 of net/adoptopenjdk/icedteaweb/resources/cache/CacheImpl.java fails withe a NPE, because it's missing the version.
in this context. This fixes a NPE on loading the cache which contains versioned and unversioned entries of a file looking up a new version eg. 6.2.4 ::i=0\13::l=http://localhost/myapp/jnlp.extension/common.jnlp::a=1706711261663:: ::i=0\0::l=http://localhost/myapp/jnlp.extension/common.jnlp::v=6.2.3::a=1706710902351::
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix extension file cache lookup in issue #932