Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable basic HTTP cookie support in Boot.java #958

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enable basic HTTP cookie support in Boot.java #958

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions core/src/main/java/net/sourceforge/jnlp/runtime/Boot.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@
import javax.swing.UIManager;
import java.io.File;
import java.net.URL;
import java.net.CookieManager;
import java.net.CookiePolicy;
import java.net.CookieHandler;
import java.security.AccessController;
import java.security.PrivilegedAction;
import java.util.Arrays;
Expand Down Expand Up @@ -111,6 +114,24 @@ public static void main(String[] args) {
int status = -42;
try {
EnvironmentPrinter.logEnvironment(args);

// Enabling java.net built-in support of HTTP cookies.
// HTTP cookies will be stored in-memory until the java process dies.
// CookiePolicy.ACCEPT_ALL is necessary to manage the cookies associated
// to a parent domain of the requested url domain.
//
// Example:
// if an HTTP response on "https://prefix.domain.extension/app/jws-store/some-package.jar" contains:
// - 1 cookie set on "prefix.domain-name.extension" domain
// - 1 cookie set on "*.domain-name.extension" domain
// CookiePolicy.ACCEPT_ALL ensures that both cookie will be send back in the next HTTP queries
// sent to the "prefix.domain-name.extension" domain, whereas CookiePolicy.ACCEPT_ORIGINAL_SERVER will filter
// the cookie set on "*.domain-name.extension" domain.

CookieManager cookieManager = new CookieManager();
cookieManager.setCookiePolicy(CookiePolicy.ACCEPT_ALL);
CookieHandler.setDefault(cookieManager);

status = mainWithReturnCode(args);
} finally {
if (status != 0) {
Expand Down