Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GPT-78] Increased padding by 2cm #346

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

feliciahmq
Copy link
Contributor

image

Increased padding above Featured By by 2 units.

@feliciahmq feliciahmq changed the title Increased padding by 2cm [GPT-78] Increased padding by 2cm Apr 2, 2024
@wei2912 wei2912 requested review from a team and wei2912 and removed request for a team April 2, 2024 04:21
Copy link
Member

@wei2912 wei2912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also delete assets/js/.Rhistory from your PR, thanks!

@@ -1,4 +1,4 @@
<section class="featuredby-wrapper container">
<section class="featuredby-wrapper container pt-2">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be increased to around pt-8? Currently I think the padding increase isn't really visible.

For ref., pt-2 means top padding of 8px, which looks like this:

image

@wei2912 wei2912 marked this pull request as draft April 5, 2024 14:51
@feliciahmq feliciahmq requested a review from wei2912 April 5, 2024 16:32
@wei2912 wei2912 marked this pull request as ready for review April 8, 2024 07:14
@wei2912 wei2912 merged commit eb681c4 into AdvisorySG:main Apr 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GPT-78] Home: Increase Padding between Our Partners and Featured By Section
2 participants