[transferwebhooks] Code generation: update services and models#1868
[transferwebhooks] Code generation: update services and models#1868AdyenAutomationBot wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors deprecation notices in the TransferData class by cleaning up inline comments and updating Javadoc tags. The review feedback suggests further improvements to documentation standards, such as using Javadoc-style comments for fields, utilizing the since attribute in the @deprecated annotation for Java 9+ compliance, and incorporating {@link} tags for better navigability.
| /* deprecated since Transfer webhooks v3: Use createdAt or updatedAt */ | ||
| @Deprecated private OffsetDateTime creationDate; |
There was a problem hiding this comment.
The deprecation notice for the creationDate field should use a Javadoc comment (/** ... */) instead of a standard block comment (/* ... */) to ensure it is correctly processed by documentation tools and IDEs. Additionally, for Java 9+ projects, it is best practice to include the since attribute in the @Deprecated annotation. Note: You should also consider deprecating the associated constant JSON_PROPERTY_CREATION_DATE (line 145) for consistency.
| /* deprecated since Transfer webhooks v3: Use createdAt or updatedAt */ | |
| @Deprecated private OffsetDateTime creationDate; | |
| /** @deprecated since Transfer webhooks v3: Use createdAt or updatedAt */ | |
| @Deprecated(since = "Transfer webhooks v3") | |
| private OffsetDateTime creationDate; |
| * @deprecated since Transfer webhooks v3 Use createdAt or updatedAt | ||
| */ | ||
| @Deprecated // deprecated since Transfer webhooks v3: Use createdAt or updatedAt | ||
| @Deprecated |
There was a problem hiding this comment.
The @deprecated tag text is missing a period and should use {@link} for better navigability in generated documentation. Also, the @Deprecated annotation should include the since attribute for clarity and compliance with Java 9+ best practices.
| * @deprecated since Transfer webhooks v3 Use createdAt or updatedAt | |
| */ | |
| @Deprecated // deprecated since Transfer webhooks v3: Use createdAt or updatedAt | |
| @Deprecated | |
| * @deprecated since Transfer webhooks v3. Use {@link #getCreatedAt()} or {@link #getUpdatedAt()} instead. | |
| */ | |
| @Deprecated(since = "Transfer webhooks v3") |
ca052df to
93cf026
Compare
93cf026 to
74daa0a
Compare
This PR contains the automated changes for the
transferwebhooksservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.