Skip to content

[transferwebhooks] Code generation: update services and models#1868

Open
AdyenAutomationBot wants to merge 1 commit intomainfrom
sdk-automation/transferwebhooks
Open

[transferwebhooks] Code generation: update services and models#1868
AdyenAutomationBot wants to merge 1 commit intomainfrom
sdk-automation/transferwebhooks

Conversation

@AdyenAutomationBot
Copy link
Copy Markdown
Collaborator

This PR contains the automated changes for the transferwebhooks service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot AdyenAutomationBot requested review from a team as code owners April 7, 2026 07:09
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors deprecation notices in the TransferData class by cleaning up inline comments and updating Javadoc tags. The review feedback suggests further improvements to documentation standards, such as using Javadoc-style comments for fields, utilizing the since attribute in the @deprecated annotation for Java 9+ compliance, and incorporating {@link} tags for better navigability.

Comment on lines +146 to +147
/* deprecated since Transfer webhooks v3: Use createdAt or updatedAt */
@Deprecated private OffsetDateTime creationDate;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The deprecation notice for the creationDate field should use a Javadoc comment (/** ... */) instead of a standard block comment (/* ... */) to ensure it is correctly processed by documentation tools and IDEs. Additionally, for Java 9+ projects, it is best practice to include the since attribute in the @Deprecated annotation. Note: You should also consider deprecating the associated constant JSON_PROPERTY_CREATION_DATE (line 145) for consistency.

Suggested change
/* deprecated since Transfer webhooks v3: Use createdAt or updatedAt */
@Deprecated private OffsetDateTime creationDate;
/** @deprecated since Transfer webhooks v3: Use createdAt or updatedAt */
@Deprecated(since = "Transfer webhooks v3")
private OffsetDateTime creationDate;

Comment on lines +1131 to +1133
* @deprecated since Transfer webhooks v3 Use createdAt or updatedAt
*/
@Deprecated // deprecated since Transfer webhooks v3: Use createdAt or updatedAt
@Deprecated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The @deprecated tag text is missing a period and should use {@link} for better navigability in generated documentation. Also, the @Deprecated annotation should include the since attribute for clarity and compliance with Java 9+ best practices.

Suggested change
* @deprecated since Transfer webhooks v3 Use createdAt or updatedAt
*/
@Deprecated // deprecated since Transfer webhooks v3: Use createdAt or updatedAt
@Deprecated
* @deprecated since Transfer webhooks v3. Use {@link #getCreatedAt()} or {@link #getUpdatedAt()} instead.
*/
@Deprecated(since = "Transfer webhooks v3")

@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/transferwebhooks branch from ca052df to 93cf026 Compare April 8, 2026 07:41
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/transferwebhooks branch from 93cf026 to 74daa0a Compare April 9, 2026 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant