Skip to content

[management] Code generation: update services and models#1877

Open
AdyenAutomationBot wants to merge 1 commit intomainfrom
sdk-automation/management
Open

[management] Code generation: update services and models#1877
AdyenAutomationBot wants to merge 1 commit intomainfrom
sdk-automation/management

Conversation

@AdyenAutomationBot
Copy link
Copy Markdown
Collaborator

This PR contains the automated changes for the management service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot AdyenAutomationBot requested review from a team as code owners April 7, 2026 07:10
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the deprecation documentation across several model files, including AndroidApp, Nexo, and UpdatePaymentMethodInfo, by transitioning from end-of-line comments to block comments and refining Javadoc tags. The review feedback recommends using standard Javadoc format instead of block comments for field deprecations to ensure better IDE support, maintaining consistency by using {@code ...} instead of backticks for code references, and addressing line length violations for improved readability.

Comment on lines +48 to +49
/* deprecated since Management API v3: Use `errors` instead. */
@Deprecated private String errorCode;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using a regular block comment (/* ... */) for deprecation is less effective than Javadoc (/** ... */), which is recognized by IDEs and documentation tools. Additionally, placing the annotation on the same line as the field can reduce visibility. It is recommended to use a multi-line Javadoc format and place the annotation on its own line.

Suggested change
/* deprecated since Management API v3: Use `errors` instead. */
@Deprecated private String errorCode;
/** @deprecated since Management API v3: Use {@code errors} instead. */
@Deprecated
private String errorCode;

* **error** or **invalid**.
* @return the current {@code AndroidApp} instance, allowing for method chaining
* @deprecated since Management API v3 Use `errors` instead.
* @deprecated since Management API v3 Use `errors` instead.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Javadoc uses backticks (`errors`) for code references, which is non-standard for Javadoc and inconsistent with the use of {@code ...} on the preceding line (line 206). It is recommended to use {@code errors} and add a period after the version for better clarity and standard compliance.

Suggested change
* @deprecated since Management API v3 Use `errors` instead.
* @deprecated Since Management API v3. Use {@code errors} instead.

Comment on lines +206 to +207
/* deprecated since Management API v3: Use `storeId` instead. Only one store per payment method is allowed. */
@Deprecated private List<String> storeIds;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This line is excessively long (114 characters), exceeding common line length limits such as the 100-character limit in Google Java Style. Furthermore, using a regular block comment for deprecation is less effective than Javadoc (/** ... */). Reverting to a multi-line Javadoc format improves readability and ensures the deprecation reason is visible in IDEs.

Suggested change
/* deprecated since Management API v3: Use `storeId` instead. Only one store per payment method is allowed. */
@Deprecated private List<String> storeIds;
/**
* @deprecated since Management API v3: Use {@code storeId} instead.
* Only one store per payment method is allowed.
*/
@Deprecated
private List<String> storeIds;

Comment on lines +1145 to +1146
* @deprecated since Management API v3 Use `storeId` instead. Only one store per payment method is
* allowed.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Javadoc uses backticks (`storeId`) for code references, which is inconsistent with the use of {@code ...} on line 1144. Standard Javadoc uses {@code ...} for code snippets. Additionally, adding a period after the version improves sentence structure.

Suggested change
* @deprecated since Management API v3 Use `storeId` instead. Only one store per payment method is
* allowed.
* @deprecated Since Management API v3. Use {@code storeId} instead.
* Only one store per payment method is allowed.

@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/management branch from 1cebd64 to 207e2ca Compare April 8, 2026 07:41
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/management branch from 207e2ca to 8cc1bf2 Compare April 9, 2026 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant