Translate drop glue for poly types #912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nadrieril
force-pushed
the
poly-drop-glue
branch
from
1c7af7f to
b175f8f
Compare
Nadrieril
changed the title
Nadrieril
force-pushed
the
poly-drop-glue
branch
2 times, most recently
from
28f3b83 to
31f8ec0
Compare
Nadrieril
force-pushed
the
poly-drop-glue
branch
from
31f8ec0 to
5842349
Compare
Nadrieril
force-pushed
the
poly-drop-glue
branch
from
5842349 to
9fa3731
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to rust-lang/rust#148719 we can now get drop glue for more non-mono types! Still not all of them unfortunately, as drop elaboration doesn't handle generics properly. This PR makes it so that
--precise-dropsretrieves drop glue for poly types, with a warning that this may cause ICEs.