Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(packet): improve packet parsing, crate structure, formatting and improved errors #3

Merged
merged 8 commits into from
Nov 6, 2024

Conversation

elpiel
Copy link
Member

@elpiel elpiel commented May 18, 2024

I still think we can:

  • Have the blocking parser enabled by default

  • Use trait Mode to abstract away the Blocking and Async modes

  • TODO: check MSRV

elpiel and others added 8 commits May 18, 2024 19:55
… errors

Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
…y and validate_frame fns

Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
# Conflicts:
#	Cargo.toml
#	src/error.rs
#	src/lib.rs
#	src/packet.rs
#	src/parser.rs
#	src/parser/asynch.rs
#	src/parser/blocking.rs
@Ragarnoy Ragarnoy self-requested a review November 6, 2024 21:47
Copy link
Collaborator

@Ragarnoy Ragarnoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yessss

@Ragarnoy Ragarnoy merged commit ec6c006 into master Nov 6, 2024
17 checks passed
@Ragarnoy Ragarnoy deleted the feat/improve-parsing-and-crate branch November 6, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants