Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add boulder update #110

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Add boulder update #110

merged 1 commit into from
Dec 29, 2023

Conversation

tarkah
Copy link
Collaborator

@tarkah tarkah commented Dec 19, 2023

image

@tarkah tarkah requested review from ikeycode and ermo as code owners December 19, 2023 20:47
@tarkah tarkah marked this pull request as draft December 19, 2023 22:51
@tarkah
Copy link
Collaborator Author

tarkah commented Dec 19, 2023

Draft until we can figure out a better solution than deserializing since that strips non-data such as comments :/

@tarkah tarkah force-pushed the feat/boulder-update branch from 22b1ef6 to bae645e Compare December 20, 2023 18:34
@tarkah tarkah changed the base branch from feat/yaml-format to main December 20, 2023 18:34
@tarkah tarkah marked this pull request as ready for review December 20, 2023 18:34
@tarkah tarkah force-pushed the feat/boulder-update branch from bae645e to a825abd Compare December 20, 2023 18:36
@tarkah tarkah force-pushed the feat/boulder-update branch from a825abd to f39a4ce Compare December 20, 2023 21:33
ermo
ermo approved these changes Dec 29, 2023
View reviewed changes
Copy link
Contributor

@ermo ermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no reason to not approve this, as we need wider testing of it.

@ermo ermo merged commit e686fcd into main Dec 29, 2023
2 checks passed
@ermo ermo deleted the feat/boulder-update branch December 29, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ermo ermo ermo approved these changes

@ikeycode ikeycode Awaiting requested review from ikeycode ikeycode is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tarkah @ermo