Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [BUG] - choosing owner need some exception check #175

Closed
ymw0407 opened this issue Oct 25, 2023 · 0 comments · Fixed by #179
Closed

🐛 [BUG] - choosing owner need some exception check #175

ymw0407 opened this issue Oct 25, 2023 · 0 comments · Fixed by #179
Assignees
@bentshrimp @hummingbbird @ancy0
Labels
bug Something isn't working

Comments

@ymw0407
Copy link
Member

ymw0407 commented Oct 25, 2023

Browsers

Firefox, Chrome, Safari, Microsoft Edge, Opera

OS

Windows, Linux, Mac

Description

image
image

If you change the Owner as shown in the picture above, you will be able to move on to the next step without checking each Repository validity! It looks like an exception is needed for parts like this!
위의 사진과 같이 Owner를 바꾸는 경우에는 각각 Repository 유효성에 대해서 체크하지 않고 다음단계로 넘어갈 수 있게 됩니다! 이와 같은 부분에 대해서 예외처리가 필요해보입니다!

Reproduction URL

https://www.open-set-go.com

Reproduction Steps

.<title>

Solutions

No response

Screenshots

![DESCRIPTION](LINK.png)
@ymw0407 ymw0407 added the bug Something isn't working label Oct 25, 2023
bentshrimp added a commit that referenced this issue Oct 25, 2023
@bentshrimp
Fix : validate new repository name on owner and repoName change #175
f45cf8d 
Signed-off-by: bentshrimp <bent_shrimp@kookmin.ac.kr>
bentshrimp added a commit that referenced this issue Oct 27, 2023
@bentshrimp
Chore : change code following the lint #175
9300396 
Signed-off-by: bentshrimp <bent_shrimp@kookmin.ac.kr>
bentshrimp added a commit that referenced this issue Oct 28, 2023
@bentshrimp
Fix : on selected Owner change, select repoName is initialized #175
181069e 
Signed-off-by: bentshrimp <bent_shrimp@kookmin.ac.kr>
This was referenced Oct 28, 2023
Closed
Merged
@bentshrimp bentshrimp linked a pull request Oct 28, 2023 that will close this issue
reset the selected repoName to nothing on selected owner change #179
Merged
11 tasks
bentshrimp added a commit that referenced this issue Oct 28, 2023
@bentshrimp
Chore : removed duplicates #175
1c2c6f4 
Signed-off-by: bentshrimp <bent_shrimp@kookmin.ac.kr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bentshrimp bentshrimp

@hummingbbird hummingbbird

@ancy0 ancy0

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

reset the selected repoName to nothing on selected owner change AgainIoT/Open-Set-Go_client
4 participants
@bentshrimp @ymw0407 @hummingbbird @ancy0