Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reset the selected repoName to nothing on selected owner change #179

Merged
merged 4 commits into from
Oct 28, 2023
Merged

reset the selected repoName to nothing on selected owner change #179

merged 4 commits into from
Oct 28, 2023

Conversation

bentshrimp
Copy link
Contributor

@bentshrimp bentshrimp commented Oct 28, 2023 •
edited by ymw0407
Loading

Describe changes

If you don't choose owner or change the selected owner, repoName selector is initialized. So you need to choose repoName again.
Also this happens right after every refresh.

Issue number or link

#175 #177

Types of changes

What is the type of code change?
Put an x in the boxes that apply

  • Bugfix (changes that resolve errors)
  • New feature (changes which adds functionality)
  • Breaking change (big changes that affect existing functionality)
  • Documentation Update

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the "README.md"
  • My code follows the style guidelines of this project
  • My changes generate no new warnings
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation
  • Any dependent changes have been merged and published in downstream modules

Further comments

Please let me know if there's anything else to explain

@bentshrimp
Fix : validate new repository name on owner and repoName change #175
f45cf8d 
Signed-off-by: bentshrimp <bent_shrimp@kookmin.ac.kr>
@bentshrimp
Chore : change code following the lint #175
9300396 
Signed-off-by: bentshrimp <bent_shrimp@kookmin.ac.kr>
@bentshrimp
Fix : on selected Owner change, select repoName is initialized #175
181069e 
Signed-off-by: bentshrimp <bent_shrimp@kookmin.ac.kr>
@bentshrimp bentshrimp requested a review from ymw0407 October 28, 2023 03:48
@bentshrimp bentshrimp self-assigned this Oct 28, 2023
@bentshrimp bentshrimp linked an issue Oct 28, 2023 that may be closed by this pull request
🐛 [BUG] - choosing owner need some exception check #175
Closed
@bentshrimp
Chore : removed duplicates #175
1c2c6f4 
Signed-off-by: bentshrimp <bent_shrimp@kookmin.ac.kr>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

ymw0407
ymw0407 approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@ymw0407 ymw0407 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@ymw0407 ymw0407 merged commit 321946b into main Oct 28, 2023
6 checks passed
@ymw0407 ymw0407 deleted the feature/175 branch October 28, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymw0407 ymw0407 ymw0407 approved these changes

Assignees

@bentshrimp bentshrimp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - choosing owner need some exception check
2 participants
@bentshrimp @ymw0407