Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring for code convention #111

Merged
merged 6 commits into from
Oct 11, 2023
Merged

Refactoring for code convention #111

merged 6 commits into from
Oct 11, 2023

Conversation

ancy0
Copy link
Contributor

@ancy0 ancy0 commented Oct 11, 2023

Describe changes

Refactor the entire code according to the rules defined by the meeting

Issue number or link

Types of changes

What is the type of code change?
Put an x in the boxes that apply

  • Bugfix (changes that resolve errors)
  • New feature (changes which adds functionality)
  • Breaking change (big changes that affect existing functionality)
  • Documentation Update

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the "README.md"
  • My code follows the style guidelines of this project
  • My changes generate no new warnings
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation
  • Any dependent changes have been merged and published in downstream modules

Further comments

Please let me know if there's anything else to explain

@ancy0 ancy0 self-assigned this Oct 11, 2023
@ancy0 ancy0 linked an issue Oct 11, 2023 that may be closed by this pull request
2 tasks
Copy link
Contributor

@sinji2102 sinji2102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Refactoring 😄

src/components/common/InputComponent.js Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@hummingbbird hummingbbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@ancy0 ancy0 merged commit 44408e1 into main Oct 11, 2023
6 checks passed
@ancy0 ancy0 deleted the feature/92 branch October 11, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 [REQUEST] - Refactoring for code convention
3 participants