Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update : send different repoData according to layout type #176 #180

Merged
merged 2 commits into from
Oct 28, 2023

Conversation

bentshrimp
Copy link
Contributor

@bentshrimp bentshrimp commented Oct 28, 2023

  • merge reviewInfo into stepInfo
  • send reviewOwner and reviewRepoName for review pages
  • send stepsOwner and stepsReponame for steps pages

Describe changes

Now generated CONTRIBUTING.md and README.md template contains the correct owner and repoName information.

Issue number or link

Types of changes

What is the type of code change?
Put an x in the boxes that apply

  • Bugfix (changes that resolve errors)
  • New feature (changes which adds functionality)
  • Breaking change (big changes that affect existing functionality)
  • Documentation Update

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the "README.md"
  • My code follows the style guidelines of this project
  • My changes generate no new warnings
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation
  • Any dependent changes have been merged and published in downstream modules

Further comments

Please let me know if there's anything else to explain

- merge reviewInfo into stepInfo
- send reviewOwner and reviewRepoName for review pages
- send stepsOwner and stepsReponame for steps pages

Signed-off-by: bentshrimp <bent_shrimp@kookmin.ac.kr>
@bentshrimp bentshrimp requested a review from ymw0407 October 28, 2023 03:51
@bentshrimp bentshrimp self-assigned this Oct 28, 2023
Copy link
Member

@ymw0407 ymw0407 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Owner and repoName seem to have the right data! However, description and license seem to have no data or problems. Please check.
owner와 repoName은 제대로 데이터가 들어간 것 같습니다! 하지만, description과 license는 데이터가 안들어오거나, 문제가 있는것 같습니다. 확인 부탁합니다.

Signed-off-by: bentshrimp <bent_shrimp@kookmin.ac.kr>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 16 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bentshrimp bentshrimp requested a review from ymw0407 October 28, 2023 07:51
Copy link
Member

@ymw0407 ymw0407 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@ymw0407 ymw0407 merged commit 8fced1f into main Oct 28, 2023
6 checks passed
@ymw0407 ymw0407 deleted the feature/176 branch October 28, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - generate feature need some change at recoil state variable
2 participants