fix(web-ui): replace vcStatus any casts with shared VCStatusData#249
Open
anujboddu wants to merge 1 commit intoAgent-Field:mainfrom
Open
fix(web-ui): replace vcStatus any casts with shared VCStatusData#249anujboddu wants to merge 1 commit intoAgent-Field:mainfrom
anujboddu wants to merge 1 commit intoAgent-Field:mainfrom
Conversation
|
|
Member
|
Hey @anujboddu — thanks for the contribution! 🙌 Before we can merge this, could you please sign our Contributor License Agreement (CLA)? It's a quick one-time thing for first-time contributors. Let us know if you have any questions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #233 by removing
vcStatus as anyusage across execution components and replacing related TSXas anycasts called out in the issue.What changed
VCStatusDatatype:control-plane/web/client/src/types/vc.tsVCStatusDatainstead of inlineany-shaped objects:CompactExecutionHeader.tsxExecutionHeader.tsxEnhancedExecutionHeader.tsxExecutionIdentityPanel.tsxExecutionHero.tsxExecutionDetailPage.tsxEnhancedExecutionDetailPage.tsxRedesignedExecutionDetailPage.tsxuseVCVerification.tsVerifiableCredentialBadgeto acceptVCStatusDatainvcData.as anypatterns listed in [Web UI] ReplacevcStatus as anypattern across execution components #233:HoverDetailPanel.tsx(typedagent_name/task_nameviaWorkflowDAGLightweightNode)ExecutionQueue.tsx(typed keyboard/mouse event handlers)EnhancedJsonViewer.tsx(typed conversions instead ofas any)EnhancedModal.tsx(typed tab value guard)ResponsiveGrid.tsx(typed forwarded ref)agent_nameandtask_nametoWorkflowDAGLightweightNode.Testing
./scripts/test-all.shnpm run buildincontrol-plane/web/clientpasses.as anyremains in the 10 TSX files listed in [Web UI] ReplacevcStatus as anypattern across execution components #233.Checklist
CHANGELOG.md(or this change does not warrant a changelog entry).Screenshots (if UI-related)
N/A (typing/refactor only).
Related issues
Fixes #233