Skip to content

Conversation

@AgentAiDrive
Copy link
Owner

Summary

  • add persistent config data and run evidence support to the database models
  • resolve recipes relative to the packaged recipes directory
  • ensure workflow execution stores phase evidence entries with the correct payload

Testing

  • pytest sma-av-streamlit/tests/test_workflow_engine.py -q

https://chatgpt.com/codex/tasks/task_e_6907136c6dbc83328ae3a8ddfc60e076

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +10 to 15
PACKAGE_ROOT = Path(__file__).resolve().parents[2]
DEFAULT_RECIPES_DIR = PACKAGE_ROOT / "recipes"
RECIPES_DIR = DEFAULT_RECIPES_DIR

__all__ = [
"ensure_recipes_dir",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Writing recipes into package directory causes permission errors

The new path resolution sets RECIPES_DIR to PACKAGE_ROOT / "recipes" and save_recipe_yaml now writes directly into that location. When the project is installed as a package, PACKAGE_ROOT resolves to the site‑packages directory, which is typically read‑only for the running user. Calls like save_recipe_yaml(fname, text) will attempt to create directories and files inside the installed package and will raise PermissionError, and other parts of the app (e.g. pages/4_Recipes.py) still look for user recipes under the working directory so the saved file would be invisible even if the write succeeded. Previously the default Path("recipes") pointed to a writable, working-directory folder. Consider keeping a writable user directory for output and only adding the packaged directory as a read-only search path.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants