fix: add GuardrailSpanData handling for proper span classification #1273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes AgentOps-AI#1105 The OpenAI Agents SDK instrumentation was missing handlers for GuardrailSpanData, causing guardrail events to be incorrectly classified as generic events instead of proper GUARDRAIL span types. Changes: - Add GuardrailSpanData case to get_span_kind() in exporter.py - Add GUARDRAIL_SPAN_ATTRIBUTES mapping in attributes/common.py - Add get_guardrail_span_attributes() function to extract guardrail attributes - Add GuardrailSpanData case to get_span_attributes() dispatcher - Add tests for guardrail span attribute extraction The guardrail spans now properly include: - guardrail.name: The name of the guardrail - guardrail.triggered: Whether the guardrail was activated - agentops.span.kind: Set to "guardrail" for proper classification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
Fixes #1105
the OpenAI Agents SDK instrumentation was missing handlers for
GuardrailSpanData, causing guardrail events to be incorrectly classified as generic events instead of properGUARDRAILspan types.problem
two functions in the OpenAI Agents SDK instrumentation were missing handlers for
GuardrailSpanData:get_span_kind()inexporter.py- didn't handleGuardrailSpanDataget_span_attributes()inattributes/common.py- didn't have a case forGuardrailSpanDatasolution
add:
GuardrailSpanDatacase toget_span_kind()returningSpanKind.INTERNALGUARDRAIL_SPAN_ATTRIBUTESmapping for attribute extractionget_guardrail_span_attributes()function to extract guardrail-specific attributesGuardrailSpanDatacase toget_span_attributes()dispatcherother changes
guardrail spans now properly include:
guardrail.name: The name of the guardrailguardrail.triggered: Whether the guardrail was activated (boolean)agentops.span.kind: Set to "guardrail" for proper classification=