Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vault state daily metrics #15

Closed
wants to merge 1 commit into from
Closed

Conversation

toliaqat
Copy link
Contributor

@toliaqat toliaqat commented May 4, 2024

No description provided.

@rabi-siddique
Copy link
Collaborator

I am using a3p latest for testing.

Daily Metrics when the Chain Starts:
image

Daily Metrics when I create 2 vaults from different accounts:
image

Shouldn't it increment the previous value of 8 active vaults to 10? And also the numClosedVaultsLast is set to 0, when I created a vault.

@rabi-siddique
Copy link
Collaborator

rabi-siddique commented May 6, 2024

After I ensure a vault is liquidating:
image

The numActiveVaultsLast is still 2.

Same when I ensure the vault is liquidated:
image

Perhaps when we are updating our counts for active, closed, liquidating and liquidated, we should decrement the previous state count? For example, if a vault is liquidating, we can do:

liquidating = 1;
active = -1;

@toliaqat toliaqat closed this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants