feat: add oraclePrice and goverance data to liquidated vaults #20
Conversation
frazarshad
force-pushed
the
feat/add-extra-info-to-liquidation
branch
from
479dbc6 to
a72a70a
Compare
| vault.coin = payload?.locked?.__brand; | ||
| vault.denom = payload?.locked?.__brand; | ||
| const vaultGovernanceId = id.split('.').slice(0, 4).join('.') + '.governance'; | ||
| const vaultManagerGovernance = await VaultManagerGovernance.get(vaultGovernanceId); |
There was a problem hiding this comment.
I think we should add optional chaining on line 96:
const vaultGovernanceId = id?.split('.')?.slice(0, 4).join('.') + '.governance';
There was a problem hiding this comment.
id here should exist in all cases. if we put optional chaining here, we will get an invalid id. crashing in case the id format is invalid would be the preferred option here
There was a problem hiding this comment.
Ahh, I see. I reckon it's the we're using the id declared on line 79?
Do you think we should have some sort of validation for id over there?
It's possible that id can have the value undefined-null.governance when path and payload?.vaultState have falsy values.
There was a problem hiding this comment.
this function is only triggered from line: src/mappings/mappingHandlers.ts:214 where we perform a regex check on the path. so there is no way it is falsy.
in any case i've added a regex check just to be safe
| const oraclePrice = await OraclePrice.get(oraclPriceId); | ||
|
|
||
| if (vaultManagerGovernance && vault.vaultManagerGovernance === undefined) | ||
| vault.vaultManagerGovernance = { |
There was a problem hiding this comment.
I think we should also handle the case when vaultManagerGovernance is an empty object. Perhaps add some fallback values?
There was a problem hiding this comment.
vaultManagerGovernace is not a json object object, but rather a class object. there is no empty state for it
This PR adds a snapshot of the
vaultManagerGovernanceand theoraclePriceat the time that a vault is liquidated. the reason for doing this is that we need to display the data at the time of liquidation in order to be accurateexample data of both a liquidated and liquidating vaults:
