set up CI with linting #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frazarshad
reviewed
Dec 10, 2024
Comment on lines
+44
to
+46
| # TODO: https://github.com/Agoric/agoric-subql/issues/8 | ||
| - name: Enable btree btree_gist | ||
| run: psql "postgresql://$DB_USER:$DB_PASS@$DB_HOST:$DB_PORT/$DB_DATABASE" -c "CREATE EXTENSION IF NOT EXISTS btree_gist;" |
There was a problem hiding this comment.
what is this used for?
There was a problem hiding this comment.
The runtime tests of mapping tests (SubQL needs this extension)
That will take more work but it will depend on these changes so I thought it would be good to land what's known.
frazarshad
reviewed
Dec 10, 2024
Comment on lines
-21
to
-24
| - name: Install subql-node-cosmos | ||
| run: yarn global add @subql/node-cosmos | ||
| - name: Run tests with Subquery Node | ||
| run: subql-node-cosmos test -f ${{ github.workspace }} |
There was a problem hiding this comment.
are these not needed anymore?
There was a problem hiding this comment.
They never actually worked. The whole workflow was disabled.
#30 will make them work.
Closed
frazarshad
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #8
This includes a bunch of changes to get CI running on PRs.