Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use a3p u17 container #45

Merged
merged 2 commits into from
Jan 9, 2025
Merged

ci: use a3p u17 container #45

merged 2 commits into from
Jan 9, 2025

Conversation

rabi-siddique
Copy link
Collaborator

No description provided.

@rabi-siddique rabi-siddique force-pushed the rs-use-u17-container branch 3 times, most recently from 77d588f to 4196c6c Compare January 7, 2025 06:36
turadg
turadg requested changes Jan 7, 2025
View reviewed changes
docker-compose.yml Outdated
@@ -72,7 +72,7 @@ services:
- ci

a3p:
image: ghcr.io/agoric/agoric-3-proposals:latest
image: ghcr.io/agoric/agoric-3-proposals:latest@sha256:dbc0232a8ed567079aefe4f5de230298f28519a29347413bec79d9b47de37db2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so it's more clear to the reader what the base is, please use the use-upgrade-17 tag. That will also help when searching the org code for what images need updating when a new one is released.

please also update https://github.com/Agoric/agoric-3-proposals/blob/main/.github/pull_request_template.md with a note to file an issue on this repo to adopt the new proposal when it's added

@rabi-siddique
Copy link
Collaborator Author

It's weird that when I index locally with the use-upgrade-17 container, it indexes vault-related data at 1170 block height, but it fails in CI. Inspecting the issue.

@rabi-siddique rabi-siddique force-pushed the rs-use-u17-container branch 4 times, most recently from 9f68185 to 63d4a4f Compare January 9, 2025 05:46
@rabi-siddique rabi-siddique force-pushed the rs-use-u17-container branch 13 times, most recently from 34111d6 to 20046f3 Compare January 9, 2025 08:05
turadg
turadg reviewed Jan 9, 2025
View reviewed changes
docker-compose.yml Outdated
@@ -72,7 +72,7 @@ services:
- ci

a3p:
image: ghcr.io/agoric/agoric-3-proposals:latest
image: ghcr.io/agoric/agoric-3-proposals:use-upgrade-17
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include the sha in case that tag changes again

scripts/validateData.mjs Outdated
@@ -18,6 +18,7 @@ const filter = dailyEntities.includes(entity) ? { blockHeightLast: blockHeight }

try {
const graphqlQuery = { query: getQuery(entity, filter) };
console.log('Fetch data for query:', graphqlQuery);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please log just the query string

Suggested change
console.log('Fetch data for query:', graphqlQuery);
console.log('Fetch data for query:', graphqlQuery.query);

Or move the property wrapping down to the other call site

@rabi-siddique rabi-siddique requested a review from turadg January 9, 2025 14:47
@rabi-siddique rabi-siddique merged commit 073e3d8 into main Jan 9, 2025
3 checks passed
@rabi-siddique rabi-siddique deleted the rs-use-u17-container branch January 9, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turadg turadg turadg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rabi-siddique @turadg