ci: nightly integration test runs #103
Conversation
mujahidkay
force-pushed
the
mk/integration-nightly
branch
2 times, most recently
from
f10c480 to
f9b206b
Compare
| @@ -21,76 +22,3 @@ jobs: | |||
| - run: yarn install | |||
| - run: yarn build | |||
| - run: yarn test | |||
| integration: | |||
There was a problem hiding this comment.
To make it a separate workflow that can run daily. Don't need the lint and unit jobs to run daily.
There was a problem hiding this comment.
Don't we want integration run on a PR? Assuming pr.yml triggeres on PR creation/push
There was a problem hiding this comment.
on:
pull_request:
determines whether it runs on a pull request or not, and its part on the integration.yml file. Filename can be anything. As you can see integration workflow being triggered on this PR right now.
There was a problem hiding this comment.
I missed on: pull_request hook in integration.yaml
We can keep one file and conditionally trigger lint and unit jobs (when github.event is pullrequest).
There was a problem hiding this comment.
Well it's just a suggestion but not a blocker.
Approving
There was a problem hiding this comment.
Nice suggestion. I'll cater to it whenever Im doing a cleanup/refactor.
Closes: #100
Notification test (by removing the failure condition)