Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Chain Selector Color #41

Closed
wants to merge 1 commit into from
Closed

Conversation

amessbee
Copy link
Contributor

Chain Selector was invisible in UI in light theme. This is a fix by changing the text color to blue. Tested to work on light and dark themes with Safari/Edge/Chrome on mac.

Also decreased font size to normal to fit the text inside the selector.

@amessbee amessbee requested a review from Jovonni September 16, 2024 07:33
@amessbee amessbee self-assigned this Sep 16, 2024
@Jovonni Jovonni force-pushed the multichain-u17-with-icq branch from a927fb8 to 220427a Compare September 19, 2024 09:11
Copy link
Contributor

@Jovonni Jovonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see many changes in here that doesn't have to do with the chain selector. You might want to reduce the size of this PR to avoid any side effects

@Jovonni
Copy link
Contributor

Jovonni commented Sep 24, 2024

also lint, tests are not passing here

@amessbee amessbee force-pushed the ms/chain-selector-color-fix branch 3 times, most recently from 6537f05 to 08e1fbe Compare September 25, 2024 04:10
@amessbee
Copy link
Contributor Author

@Jovonni cleaned up!

@dckc dckc force-pushed the multichain-u17-with-icq branch 2 times, most recently from f09810b to d3144de Compare September 26, 2024 00:44
@amessbee amessbee force-pushed the ms/chain-selector-color-fix branch from 08e1fbe to 972e5ff Compare September 26, 2024 10:22
@dckc dckc force-pushed the multichain-u17-with-icq branch from 8b03e17 to d3144de Compare September 26, 2024 16:27
@amessbee amessbee changed the base branch from multichain-u17-with-icq to main September 27, 2024 07:49
@amessbee amessbee force-pushed the ms/chain-selector-color-fix branch from 972e5ff to e04444a Compare September 27, 2024 07:51
@amessbee amessbee requested review from Jovonni and dckc September 27, 2024 08:05
Copy link
Contributor

@Jovonni Jovonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may not be needed now due to 851254b

@amessbee amessbee closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants