Adding Instructions to build agd
#1206
Conversation
Deploying documentation with
|
| Latest commit: |
65a4468
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://321a12b2.documentation-7tp.pages.dev |
| Branch Preview URL: | https://ms-add-building-agd-instruct.documentation-7tp.pages.dev |
| cd agoric-sdk | ||
| SKIP_DOWNLOAD=false ./bin/agd build | ||
| export PATH=$PWD/bin:$PATH | ||
| ``` |
There was a problem hiding this comment.
This page talks about how we're just another cosmos chain, which suggests that agd would be a single-file binary. But it's not. I suggest including something like this blurb from recent release notes:
Unlike typical cosmos-sdk chains where the daemon is a single executable file, Agoric's use of cosmos-sdk depends on many components of agoric-sdk at runtime. Copying
agdto/usr/local/binor the like is unlikely to produce a working installation. For more detail, see: #7825.
|
never mind the recommendation to wait for more reviews; I see @mhofman endorsed this approach in #1203 (comment) |
There was a problem hiding this comment.
While I'm here, looks like there are other changes needed in this file, possibly for another PR:
The chain is currently based on cosmos-sdk 0.46. But as Dan mentions, the general cosmos docs are only partially relevant given the amount of customization we have made.
The API endpoint should likely be updated to https://main.api.agoric.net
There was a problem hiding this comment.
Agreed but I propose to go for another PR. @dckc and I had a discussion about updating this page before, and Dan created an issue too. I can update that issue with more details or create a new one and come back to it in a week or so?
| The `agd` command line tool can be built as described in the Agoric [getting-started documentation](https://docs.agoric.com/guides/getting-started#build-the-cosmic-swingset-package). The linked step builds `agd`. To confirm that `agd` is in your `$PATH`, execute | ||
| The `agd` command line tool can be built by running the commands as below: | ||
| ```sh | ||
| git clone https://github.com/Agoric/agoric-sdk |
There was a problem hiding this comment.
I am wondering if we should have a specific tag/branch to checkout for now, possibly agoric-upgrade-16 until we figure out an evergreen community-dev branch? Alternatively I could force-push community-dev now, since that is supposed to be updated in for upgrade-17 (it's now in the runbook).
There was a problem hiding this comment.
Sure, let's go for community-dev branch if we plan to maintain its status as evergreen in future.
There was a problem hiding this comment.
I updated community-dev and we plan on keeping it up to date, so let's check out that branch instead of master
There was a problem hiding this comment.
I have updated the docs to point to community-dev instead of master.
|
Cloudflare deployment logs are available here |
The change goes in
chain-integration.mdpage where it was designated to be before this change.closes: #1203