Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users Authentication Requests/Responses #53

Merged
merged 47 commits into from
May 9, 2024

Conversation

Akram-Fahim
Copy link
Collaborator

What

Added all required Authentication (register/login) requests and responses.

Test

Added new request and response objects to the serialization test

Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>
…nses

Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>
Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>
Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>
…nses

Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>
Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>
Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>
Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>
Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>
@pull-request-size pull-request-size bot added size/M and removed size/L labels Apr 28, 2024
Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>
Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>
Copy link
Collaborator

@Pandemic1617 Pandemic1617 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment, otherwise LGTM

Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>
@Akram-Fahim Akram-Fahim dismissed Ahmad45123’s stale review May 9, 2024 10:49

Changes addressed

@Akram-Fahim Akram-Fahim changed the base branch from main to users-command-implementation May 9, 2024 11:47
Akram-Fahim added 14 commits May 9, 2024 14:49
…nses

Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>
…nses

Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>
Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>
Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>
Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>
Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>
Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>
@Akram-Fahim Akram-Fahim merged commit ce813b7 into users-command-implementation May 9, 2024
1 check failed
@Akram-Fahim Akram-Fahim deleted the users-auth branch May 9, 2024 11:51
Ahmad45123 added a commit that referenced this pull request May 10, 2024
* Created Users module, and added FreelancerRegister request and response

* Updated added builder annotation to FreelancerRegisterResponse and removed redundant @nonnull

* Removed the NonNull annotation to make the class compatible with the Builder annotation

* Addressed @Ahmad45123's comments and created a test to verify the serialization process.

* Added the DB Schema discussed in the meeting with all of its required dependencies

URL: https://docs.spring.io/spring-data/mongodb/reference/mongodb/mapping/document-references.html
Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>

* Deleted commented file

Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>

* Added Client Schema (I forgot about it last time :|)

Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>

* Added Empty Lines to remove GitHub Warnings

Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>

* added some commands

* organized imports

* added Client Get Profile

* added photo requests

* added resume command

* added user command map

* small fix

removed default value for success

* feat: Add freelancer skills CRUD

* feat: Add Freelancer language CRUD

* feat: Add freelancer education CRUD

* feat: Add freelancer experiences CRUD

* feat: Add freelancer achievement CRUD

* fix: Add db repositories

* fix: Add repositories to the user command and add document collections

* lint: Use linting

* refactored requests and responses into shared folder

* fix: Change withSuccess to withStatusCode

* added tests template

* refactored code to use http satus code

* added rabbitmq listeners

* added env vars and small fixes

* reformat

* reformat

* builds successfully

* tests working using test containers

* fix: Update user profile CRUD

Update the user profile CRUD for better information hiding and move the requests and responses into the shared folder

* fix: Remove duplicate files

* feat: Add user profile commands to the command map

* feat: Add all freelancer profile CRUD operations (#54)

* feat: Add freelancer skills CRUD

* feat: Add Freelancer language CRUD

* feat: Add freelancer education CRUD

* feat: Add freelancer experiences CRUD

* feat: Add freelancer achievement CRUD

* fix: Add db repositories

* fix: Add repositories to the user command and add document collections

* lint: Use linting

* fix: Change withSuccess to withStatusCode

* Payments `GetWallet` and `CreateWallet` unit testing  (#58)

* Added `GetWallet` request and response

* Added `CreatePaymentRequest` request/response

* Added inheritance from the Command Request and Response class to the

* Added  request/response

* Added `createWallet` and `getWallet` unit testing

---------

Co-authored-by: AhmedNasserG <ahmednasser217217@gmail.com>
Co-authored-by: Abdulaziz-Hassan <abdulazizhza@gmail.com>

* fix: Update user profile CRUD

Update the user profile CRUD for better information hiding and move the requests and responses into the shared folder

* fix: Remove duplicate files

---------

Co-authored-by: Abdullah Ahmad Fouad <57245606+Abdullah204@users.noreply.github.com>
Co-authored-by: AhmedNasserG <ahmednasser217217@gmail.com>
Co-authored-by: Abdulaziz-Hassan <abdulazizhza@gmail.com>

* feat: Add function handlers to RabbitMQ

* feat: Create UsersTestUtils to contain redundant testing logic

* feat: Add test for adding functionality

Added tests for the Adding operations and changed the implementation to use the userId in the CommandRequest class

* feat: Create views for education, experience and achievements

feat: Create views for education, experience and achievements and update the commands to use userId in the CommandRequest class

* fix: Update tests and commands to use userId in the CommandRequest class

* added client set photo commands

* added missing rabbitmq listeners

* added tests for freelancer and client endpoints

* test: Add testing for the update requests

* fix: Change the update commands to use userId instead of freelancer_id

* test: Add tests for delete operations

Add tests for delete operations and change the commands to use userId instead of freelancer_id

* added formatting make command

* small refactor that isolated test utils

* changed naming standard for request endpoints to camelCase

* Users Authentication Requests/Responses (#53)

* Created Users module, and added FreelancerRegister request and response

* Updated added builder annotation to FreelancerRegisterResponse and removed redundant @nonnull

* Removed the NonNull annotation to make the class compatible with the Builder annotation

* Addressed @Ahmad45123's comments and created a test to verify the serialization process.

* Deleted commented file

Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>

* Revert "Deleted commented file"

This reverts commit f9b11cf.

* Added all required Authentication (register/login) requests and responses

Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>

* Deleted useless file

Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>

* Created Users module, and added FreelancerRegister request and response

* Updated added builder annotation to FreelancerRegisterResponse and removed redundant @nonnull

* Removed the NonNull annotation to make the class compatible with the Builder annotation

* Addressed @Ahmad45123's comments and created a test to verify the serialization process.

* Deleted commented file

Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>

* Revert "Deleted commented file"

This reverts commit f9b11cf.

* Added all required Authentication (register/login) requests and responses

Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>

* Deleted useless file

Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>

* Created Users module, and added FreelancerRegister request and response

* Updated added builder annotation to FreelancerRegisterResponse and removed redundant @nonnull

* Removed the NonNull annotation to make the class compatible with the Builder annotation

* Addressed @Ahmad45123's comments and created a test to verify the serialization process.

* Deleted commented file

Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>

* Revert "Deleted commented file"

This reverts commit f9b11cf.

* Added all required Authentication (register/login) requests and responses

Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>

* Deleted useless file

Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>

* Updated the annotations to match the ones requested by @Ahmad45123

Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>

* Linting

Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>

* Linting

Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>

* Handled Inheritance bug

Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>

* Removed the success boolean as suggested by @Ahmad45123

Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>

* Addressed Noureldin's comments

Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>

* Created Users module, and added FreelancerRegister request and response

* Addressed @Ahmad45123's comments and created a test to verify the serialization process.

* Created Users module, and added FreelancerRegister request and response

* Addressed @Ahmad45123's comments and created a test to verify the serialization process.

* Added all required Authentication (register/login) requests and responses

Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>

* Created Users module, and added FreelancerRegister request and response

* Addressed @Ahmad45123's comments and created a test to verify the serialization process.

* Added all required Authentication (register/login) requests and responses

Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>

* Updated the annotations to match the ones requested by @Ahmad45123

Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>

* Linting

Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>

* Handled Inheritance bug

Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>

* Removed the success boolean as suggested by @Ahmad45123

Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>

* Addressed Noureldin's comments

Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>

---------

Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>

* Linting

Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>

* Deleted empty file

Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>

* Restored accidentally deleted file

Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>

* Users auth commands (#83)

---------

Signed-off-by: Akram-Fahim <akramadel2001@gmail.com>
Co-authored-by: Akram-Fahim <akramadel2001@gmail.com>
Co-authored-by: Mahmoud Gaber <mahmoudhosam44@gmail.com>
Co-authored-by: Mahmoud Gaber <89939442+MahmoudHosamGaber@users.noreply.github.com>
Co-authored-by: Abdullah Ahmad Fouad <57245606+Abdullah204@users.noreply.github.com>
Co-authored-by: AhmedNasserG <ahmednasser217217@gmail.com>
Co-authored-by: Abdulaziz-Hassan <abdulazizhza@gmail.com>
Co-authored-by: Ahmed Elwasefi <a.m.elwasefi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants