feat: Add all freelancer profile CRUD operations#54
Merged
Ahmad45123 merged 16 commits intousers-command-implementationfrom May 5, 2024
Merged
feat: Add all freelancer profile CRUD operations#54Ahmad45123 merged 16 commits intousers-command-implementationfrom
Ahmad45123 merged 16 commits intousers-command-implementationfrom
Conversation
MahmoudHosamGaber
requested review from
Ahmad45123,
Akram-Fahim and
Pandemic1617
as code owners
MahmoudHosamGaber
requested review from
Abdulaziz-Hassan,
Abdullah204,
Adam2431,
AhmedNasserG,
HusseinYasser,
Kemosalamy,
ShimaaBetah,
abd0123,
aboueleyes,
marsafy1 and
ziadsadek999
as code owners
* Added `GetWallet` request and response * Added `CreatePaymentRequest` request/response * Added inheritance from the Command Request and Response class to the * Added request/response * Added `createWallet` and `getWallet` unit testing --------- Co-authored-by: AhmedNasserG <ahmednasser217217@gmail.com> Co-authored-by: Abdulaziz-Hassan <abdulazizhza@gmail.com>
Update the user profile CRUD for better information hiding and move the requests and responses into the shared folder
Pandemic1617
reviewed
May 2, 2024
Collaborator
Pandemic1617
left a comment
Pandemic1617
left a comment
There was a problem hiding this comment.
the MongoDB repositories are duplicated in the db folder.
Imports that use the repositories in the db package should be updated to use the repositories in the repositories package
Comment on lines
+1
to
+5
| package com.workup.users.db; | ||
|
|
||
| import org.springframework.data.mongodb.repository.MongoRepository; | ||
|
|
||
| public interface AchievementRepository extends MongoRepository<Achievement, String> {} |
Collaborator
There was a problem hiding this comment.
duplicate file. already exists in repositories
Comment on lines
+1
to
+5
| package com.workup.users.db; | ||
|
|
||
| import org.springframework.data.mongodb.repository.MongoRepository; | ||
|
|
||
| public interface EducationRepository extends MongoRepository<Education, String> {} |
Collaborator
There was a problem hiding this comment.
duplicate file. already exists in repositories
Comment on lines
+1
to
+5
| package com.workup.users.db; | ||
|
|
||
| import org.springframework.data.mongodb.repository.MongoRepository; | ||
|
|
||
| public interface ExperienceRepository extends MongoRepository<Experience, String> {} |
Collaborator
There was a problem hiding this comment.
duplicate file. already exists in repositories
Comment on lines
+1
to
+5
| package com.workup.users.db; | ||
|
|
||
| import org.springframework.data.mongodb.repository.MongoRepository; | ||
|
|
||
| public interface FreelancerRepository extends MongoRepository<Freelancer, String> {} |
Collaborator
There was a problem hiding this comment.
duplicate file. already exists in repositories
Pandemic1617
approved these changes
May 5, 2024
Ahmad45123
added a commit
that referenced
this pull request
May 10, 2024
* Created Users module, and added FreelancerRegister request and response * Updated added builder annotation to FreelancerRegisterResponse and removed redundant @nonnull * Removed the NonNull annotation to make the class compatible with the Builder annotation * Addressed @Ahmad45123's comments and created a test to verify the serialization process. * Added the DB Schema discussed in the meeting with all of its required dependencies URL: https://docs.spring.io/spring-data/mongodb/reference/mongodb/mapping/document-references.html Signed-off-by: Akram-Fahim <akramadel2001@gmail.com> * Deleted commented file Signed-off-by: Akram-Fahim <akramadel2001@gmail.com> * Added Client Schema (I forgot about it last time :|) Signed-off-by: Akram-Fahim <akramadel2001@gmail.com> * Added Empty Lines to remove GitHub Warnings Signed-off-by: Akram-Fahim <akramadel2001@gmail.com> * added some commands * organized imports * added Client Get Profile * added photo requests * added resume command * added user command map * small fix removed default value for success * feat: Add freelancer skills CRUD * feat: Add Freelancer language CRUD * feat: Add freelancer education CRUD * feat: Add freelancer experiences CRUD * feat: Add freelancer achievement CRUD * fix: Add db repositories * fix: Add repositories to the user command and add document collections * lint: Use linting * refactored requests and responses into shared folder * fix: Change withSuccess to withStatusCode * added tests template * refactored code to use http satus code * added rabbitmq listeners * added env vars and small fixes * reformat * reformat * builds successfully * tests working using test containers * fix: Update user profile CRUD Update the user profile CRUD for better information hiding and move the requests and responses into the shared folder * fix: Remove duplicate files * feat: Add user profile commands to the command map * feat: Add all freelancer profile CRUD operations (#54) * feat: Add freelancer skills CRUD * feat: Add Freelancer language CRUD * feat: Add freelancer education CRUD * feat: Add freelancer experiences CRUD * feat: Add freelancer achievement CRUD * fix: Add db repositories * fix: Add repositories to the user command and add document collections * lint: Use linting * fix: Change withSuccess to withStatusCode * Payments `GetWallet` and `CreateWallet` unit testing (#58) * Added `GetWallet` request and response * Added `CreatePaymentRequest` request/response * Added inheritance from the Command Request and Response class to the * Added request/response * Added `createWallet` and `getWallet` unit testing --------- Co-authored-by: AhmedNasserG <ahmednasser217217@gmail.com> Co-authored-by: Abdulaziz-Hassan <abdulazizhza@gmail.com> * fix: Update user profile CRUD Update the user profile CRUD for better information hiding and move the requests and responses into the shared folder * fix: Remove duplicate files --------- Co-authored-by: Abdullah Ahmad Fouad <57245606+Abdullah204@users.noreply.github.com> Co-authored-by: AhmedNasserG <ahmednasser217217@gmail.com> Co-authored-by: Abdulaziz-Hassan <abdulazizhza@gmail.com> * feat: Add function handlers to RabbitMQ * feat: Create UsersTestUtils to contain redundant testing logic * feat: Add test for adding functionality Added tests for the Adding operations and changed the implementation to use the userId in the CommandRequest class * feat: Create views for education, experience and achievements feat: Create views for education, experience and achievements and update the commands to use userId in the CommandRequest class * fix: Update tests and commands to use userId in the CommandRequest class * added client set photo commands * added missing rabbitmq listeners * added tests for freelancer and client endpoints * test: Add testing for the update requests * fix: Change the update commands to use userId instead of freelancer_id * test: Add tests for delete operations Add tests for delete operations and change the commands to use userId instead of freelancer_id * added formatting make command * small refactor that isolated test utils * changed naming standard for request endpoints to camelCase * Users Authentication Requests/Responses (#53) * Created Users module, and added FreelancerRegister request and response * Updated added builder annotation to FreelancerRegisterResponse and removed redundant @nonnull * Removed the NonNull annotation to make the class compatible with the Builder annotation * Addressed @Ahmad45123's comments and created a test to verify the serialization process. * Deleted commented file Signed-off-by: Akram-Fahim <akramadel2001@gmail.com> * Revert "Deleted commented file" This reverts commit f9b11cf. * Added all required Authentication (register/login) requests and responses Signed-off-by: Akram-Fahim <akramadel2001@gmail.com> * Deleted useless file Signed-off-by: Akram-Fahim <akramadel2001@gmail.com> * Created Users module, and added FreelancerRegister request and response * Updated added builder annotation to FreelancerRegisterResponse and removed redundant @nonnull * Removed the NonNull annotation to make the class compatible with the Builder annotation * Addressed @Ahmad45123's comments and created a test to verify the serialization process. * Deleted commented file Signed-off-by: Akram-Fahim <akramadel2001@gmail.com> * Revert "Deleted commented file" This reverts commit f9b11cf. * Added all required Authentication (register/login) requests and responses Signed-off-by: Akram-Fahim <akramadel2001@gmail.com> * Deleted useless file Signed-off-by: Akram-Fahim <akramadel2001@gmail.com> * Created Users module, and added FreelancerRegister request and response * Updated added builder annotation to FreelancerRegisterResponse and removed redundant @nonnull * Removed the NonNull annotation to make the class compatible with the Builder annotation * Addressed @Ahmad45123's comments and created a test to verify the serialization process. * Deleted commented file Signed-off-by: Akram-Fahim <akramadel2001@gmail.com> * Revert "Deleted commented file" This reverts commit f9b11cf. * Added all required Authentication (register/login) requests and responses Signed-off-by: Akram-Fahim <akramadel2001@gmail.com> * Deleted useless file Signed-off-by: Akram-Fahim <akramadel2001@gmail.com> * Updated the annotations to match the ones requested by @Ahmad45123 Signed-off-by: Akram-Fahim <akramadel2001@gmail.com> * Linting Signed-off-by: Akram-Fahim <akramadel2001@gmail.com> * Linting Signed-off-by: Akram-Fahim <akramadel2001@gmail.com> * Handled Inheritance bug Signed-off-by: Akram-Fahim <akramadel2001@gmail.com> * Removed the success boolean as suggested by @Ahmad45123 Signed-off-by: Akram-Fahim <akramadel2001@gmail.com> * Addressed Noureldin's comments Signed-off-by: Akram-Fahim <akramadel2001@gmail.com> * Created Users module, and added FreelancerRegister request and response * Addressed @Ahmad45123's comments and created a test to verify the serialization process. * Created Users module, and added FreelancerRegister request and response * Addressed @Ahmad45123's comments and created a test to verify the serialization process. * Added all required Authentication (register/login) requests and responses Signed-off-by: Akram-Fahim <akramadel2001@gmail.com> * Created Users module, and added FreelancerRegister request and response * Addressed @Ahmad45123's comments and created a test to verify the serialization process. * Added all required Authentication (register/login) requests and responses Signed-off-by: Akram-Fahim <akramadel2001@gmail.com> * Updated the annotations to match the ones requested by @Ahmad45123 Signed-off-by: Akram-Fahim <akramadel2001@gmail.com> * Linting Signed-off-by: Akram-Fahim <akramadel2001@gmail.com> * Handled Inheritance bug Signed-off-by: Akram-Fahim <akramadel2001@gmail.com> * Removed the success boolean as suggested by @Ahmad45123 Signed-off-by: Akram-Fahim <akramadel2001@gmail.com> * Addressed Noureldin's comments Signed-off-by: Akram-Fahim <akramadel2001@gmail.com> --------- Signed-off-by: Akram-Fahim <akramadel2001@gmail.com> * Linting Signed-off-by: Akram-Fahim <akramadel2001@gmail.com> * Deleted empty file Signed-off-by: Akram-Fahim <akramadel2001@gmail.com> * Restored accidentally deleted file Signed-off-by: Akram-Fahim <akramadel2001@gmail.com> * Users auth commands (#83) --------- Signed-off-by: Akram-Fahim <akramadel2001@gmail.com> Co-authored-by: Akram-Fahim <akramadel2001@gmail.com> Co-authored-by: Mahmoud Gaber <mahmoudhosam44@gmail.com> Co-authored-by: Mahmoud Gaber <89939442+MahmoudHosamGaber@users.noreply.github.com> Co-authored-by: Abdullah Ahmad Fouad <57245606+Abdullah204@users.noreply.github.com> Co-authored-by: AhmedNasserG <ahmednasser217217@gmail.com> Co-authored-by: Abdulaziz-Hassan <abdulazizhza@gmail.com> Co-authored-by: Ahmed Elwasefi <a.m.elwasefi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add CRUD operations of the following classes: